[libc-commits] [libc] [libc] Migrate stdio tests to ErrnoCheckingTest. (PR #143802)

Wed Jun 11 16:26:18 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `libc-x86_64-debian-fullbuild-dbg-asan` running on `libc-x86_64-debian-fullbuild` while building `libc` at step 4 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/171/builds/23685

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 4 (annotate) failure: 'python ../llvm-zorg/zorg/buildbot/builders/annotated/libc-linux.py ...' (failure)
...
[==========] Running 1 test from 1 test suite.
[ RUN      ] LlvmLibcMemcpyTest.SizeSweep
[       OK ] LlvmLibcMemcpyTest.SizeSweep (2 ms)
Ran 1 tests.  PASS: 1  FAIL: 0
[928/1221] Running unit test libc.test.src.string.memcpy_x86_64_opt_sw_prefetch_avx_test.__unit__
[==========] Running 1 test from 1 test suite.
[ RUN      ] LlvmLibcMemcpyTest.SizeSweep
[       OK ] LlvmLibcMemcpyTest.SizeSweep (3 ms)
Ran 1 tests.  PASS: 1  FAIL: 0
[929/1221] Building CXX object libc/test/src/stdio/CMakeFiles/libc.test.src.stdio.setvbuf_test.__unit__.__build__.dir/setvbuf_test.cpp.o
FAILED: libc/test/src/stdio/CMakeFiles/libc.test.src.stdio.setvbuf_test.__unit__.__build__.dir/setvbuf_test.cpp.o 
/usr/bin/clang++ -DLIBC_NAMESPACE=__llvm_libc_20_0_0_git -D_DEBUG -I/home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian-fullbuild/libc-x86_64-debian-fullbuild-dbg-asan/llvm-project/libc -isystem /home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian-fullbuild/libc-x86_64-debian-fullbuild-dbg-asan/build/libc/include -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fno-omit-frame-pointer -fsanitize=address -fdiagnostics-color -g -DLIBC_QSORT_IMPL=LIBC_QSORT_QUICK_SORT -DLIBC_ADD_NULL_CHECKS -fpie -DLIBC_FULL_BUILD -ffreestanding -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-rtti -Wconversion -Wno-sign-conversion -Wimplicit-fallthrough -Wwrite-strings -Wno-c99-extensions -Wno-gnu-imaginary-constant -Wno-pedantic -Wstrict-prototypes -Wextra-semi -Wnewline-eof -Wnonportable-system-include-path -Wthread-safety -std=gnu++17 -MD -MT libc/test/src/stdio/CMakeFiles/libc.test.src.stdio.setvbuf_test.__unit__.__build__.dir/setvbuf_test.cpp.o -MF libc/test/src/stdio/CMakeFiles/libc.test.src.stdio.setvbuf_test.__unit__.__build__.dir/setvbuf_test.cpp.o.d -o libc/test/src/stdio/CMakeFiles/libc.test.src.stdio.setvbuf_test.__unit__.__build__.dir/setvbuf_test.cpp.o -c /home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian-fullbuild/libc-x86_64-debian-fullbuild-dbg-asan/llvm-project/libc/test/src/stdio/setvbuf_test.cpp
/home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian-fullbuild/libc-x86_64-debian-fullbuild-dbg-asan/llvm-project/libc/test/src/stdio/setvbuf_test.cpp:18:54: error: no type named 'ErrnoCheckingTest' in namespace '__llvm_libc_20_0_0_git::testing'
using LlvmLibcSetvbufTest = LIBC_NAMESPACE::testing::ErrnoCheckingTest;
                            ~~~~~~~~~~~~~~~~~~~~~~~~~^
/home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian-fullbuild/libc-x86_64-debian-fullbuild-dbg-asan/llvm-project/libc/test/src/stdio/setvbuf_test.cpp:20:8: error: expected class name
TEST_F(LlvmLibcSetvbufTest, SetNBFBuffer) {
       ^
/home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian-fullbuild/libc-x86_64-debian-fullbuild-dbg-asan/llvm-project/libc/test/src/stdio/setvbuf_test.cpp:20:1: error: only virtual member functions can be marked 'override'
TEST_F(LlvmLibcSetvbufTest, SetNBFBuffer) {
^
/home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian-fullbuild/libc-x86_64-debian-fullbuild-dbg-asan/llvm-project/libc/test/UnitTest/LibcTest.h:397:16: note: expanded from macro 'TEST_F'
    void Run() override;                                                       \
               ^
/home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian-fullbuild/libc-x86_64-debian-fullbuild-dbg-asan/llvm-project/libc/test/src/stdio/setvbuf_test.cpp:20:1: error: only virtual member functions can be marked 'override'
/home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian-fullbuild/libc-x86_64-debian-fullbuild-dbg-asan/llvm-project/libc/test/UnitTest/LibcTest.h:398:33: note: expanded from macro 'TEST_F'
    const char *getName() const override { return #SuiteClass "." #TestName; } \
                                ^
/home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian-fullbuild/libc-x86_64-debian-fullbuild-dbg-asan/llvm-project/libc/test/src/stdio/setvbuf_test.cpp:20:1: error: use of undeclared identifier 'addTest'
/home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian-fullbuild/libc-x86_64-debian-fullbuild-dbg-asan/llvm-project/libc/test/UnitTest/LibcTest.h:396:33: note: expanded from macro 'TEST_F'
    SuiteClass##_##TestName() { addTest(this); }                               \
                                ^
/home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian-fullbuild/libc-x86_64-debian-fullbuild-dbg-asan/llvm-project/libc/test/src/stdio/setvbuf_test.cpp:28:3: error: no matching function for call to 'test'
  ASSERT_FALSE(fw == nullptr);
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian-fullbuild/libc-x86_64-debian-fullbuild-dbg-asan/llvm-project/libc/test/UnitTest/LibcTest.h:462:27: note: expanded from macro 'ASSERT_FALSE'
#define ASSERT_FALSE(VAL) ASSERT_EQ(VAL, false)
                          ^~~~~~~~~~~~~~~~~~~~~
/home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian-fullbuild/libc-x86_64-debian-fullbuild-dbg-asan/llvm-project/libc/test/UnitTest/LibcTest.h:438:29: note: expanded from macro 'ASSERT_EQ'
#define ASSERT_EQ(LHS, RHS) LIBC_TEST_BINOP_(EQ, LHS, RHS, return)
                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian-fullbuild/libc-x86_64-debian-fullbuild-dbg-asan/llvm-project/libc/test/UnitTest/LibcTest.h:430:26: note: expanded from macro 'LIBC_TEST_BINOP_'
  LIBC_TEST_SCAFFOLDING_(test(LIBC_NAMESPACE::testing::TestCond::COND, LHS,    \
                         ^~~~
/home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian-fullbuild/libc-x86_64-debian-fullbuild-dbg-asan/llvm-project/libc/test/UnitTest/LibcTest.h:423:7: note: expanded from macro 'LIBC_TEST_SCAFFOLDING_'
  if (TEST)                                                                    \
      ^~~~
/home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian-fullbuild/libc-x86_64-debian-fullbuild-dbg-asan/llvm-project/libc/test/UnitTest/LibcTest.h:99:6: note: candidate function template not viable: requires 7 arguments, but 6 were provided
bool test(RunContext *Ctx, TestCond Cond, ValType LHS, ValType RHS,
Step 8 (libc-unit-tests) failure: libc-unit-tests (failure)
...
[==========] Running 1 test from 1 test suite.
[ RUN      ] LlvmLibcMemcpyTest.SizeSweep
[       OK ] LlvmLibcMemcpyTest.SizeSweep (2 ms)
Ran 1 tests.  PASS: 1  FAIL: 0
[928/1221] Running unit test libc.test.src.string.memcpy_x86_64_opt_sw_prefetch_avx_test.__unit__
[==========] Running 1 test from 1 test suite.
[ RUN      ] LlvmLibcMemcpyTest.SizeSweep
[       OK ] LlvmLibcMemcpyTest.SizeSweep (3 ms)
Ran 1 tests.  PASS: 1  FAIL: 0
[929/1221] Building CXX object libc/test/src/stdio/CMakeFiles/libc.test.src.stdio.setvbuf_test.__unit__.__build__.dir/setvbuf_test.cpp.o
FAILED: libc/test/src/stdio/CMakeFiles/libc.test.src.stdio.setvbuf_test.__unit__.__build__.dir/setvbuf_test.cpp.o 
/usr/bin/clang++ -DLIBC_NAMESPACE=__llvm_libc_20_0_0_git -D_DEBUG -I/home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian-fullbuild/libc-x86_64-debian-fullbuild-dbg-asan/llvm-project/libc -isystem /home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian-fullbuild/libc-x86_64-debian-fullbuild-dbg-asan/build/libc/include -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fno-omit-frame-pointer -fsanitize=address -fdiagnostics-color -g -DLIBC_QSORT_IMPL=LIBC_QSORT_QUICK_SORT -DLIBC_ADD_NULL_CHECKS -fpie -DLIBC_FULL_BUILD -ffreestanding -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-rtti -Wconversion -Wno-sign-conversion -Wimplicit-fallthrough -Wwrite-strings -Wno-c99-extensions -Wno-gnu-imaginary-constant -Wno-pedantic -Wstrict-prototypes -Wextra-semi -Wnewline-eof -Wnonportable-system-include-path -Wthread-safety -std=gnu++17 -MD -MT libc/test/src/stdio/CMakeFiles/libc.test.src.stdio.setvbuf_test.__unit__.__build__.dir/setvbuf_test.cpp.o -MF libc/test/src/stdio/CMakeFiles/libc.test.src.stdio.setvbuf_test.__unit__.__build__.dir/setvbuf_test.cpp.o.d -o libc/test/src/stdio/CMakeFiles/libc.test.src.stdio.setvbuf_test.__unit__.__build__.dir/setvbuf_test.cpp.o -c /home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian-fullbuild/libc-x86_64-debian-fullbuild-dbg-asan/llvm-project/libc/test/src/stdio/setvbuf_test.cpp
/home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian-fullbuild/libc-x86_64-debian-fullbuild-dbg-asan/llvm-project/libc/test/src/stdio/setvbuf_test.cpp:18:54: error: no type named 'ErrnoCheckingTest' in namespace '__llvm_libc_20_0_0_git::testing'
using LlvmLibcSetvbufTest = LIBC_NAMESPACE::testing::ErrnoCheckingTest;
                            ~~~~~~~~~~~~~~~~~~~~~~~~~^
/home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian-fullbuild/libc-x86_64-debian-fullbuild-dbg-asan/llvm-project/libc/test/src/stdio/setvbuf_test.cpp:20:8: error: expected class name
TEST_F(LlvmLibcSetvbufTest, SetNBFBuffer) {
       ^
/home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian-fullbuild/libc-x86_64-debian-fullbuild-dbg-asan/llvm-project/libc/test/src/stdio/setvbuf_test.cpp:20:1: error: only virtual member functions can be marked 'override'
TEST_F(LlvmLibcSetvbufTest, SetNBFBuffer) {
^
/home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian-fullbuild/libc-x86_64-debian-fullbuild-dbg-asan/llvm-project/libc/test/UnitTest/LibcTest.h:397:16: note: expanded from macro 'TEST_F'
    void Run() override;                                                       \
               ^
/home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian-fullbuild/libc-x86_64-debian-fullbuild-dbg-asan/llvm-project/libc/test/src/stdio/setvbuf_test.cpp:20:1: error: only virtual member functions can be marked 'override'
/home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian-fullbuild/libc-x86_64-debian-fullbuild-dbg-asan/llvm-project/libc/test/UnitTest/LibcTest.h:398:33: note: expanded from macro 'TEST_F'
    const char *getName() const override { return #SuiteClass "." #TestName; } \
                                ^
/home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian-fullbuild/libc-x86_64-debian-fullbuild-dbg-asan/llvm-project/libc/test/src/stdio/setvbuf_test.cpp:20:1: error: use of undeclared identifier 'addTest'
/home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian-fullbuild/libc-x86_64-debian-fullbuild-dbg-asan/llvm-project/libc/test/UnitTest/LibcTest.h:396:33: note: expanded from macro 'TEST_F'
    SuiteClass##_##TestName() { addTest(this); }                               \
                                ^
/home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian-fullbuild/libc-x86_64-debian-fullbuild-dbg-asan/llvm-project/libc/test/src/stdio/setvbuf_test.cpp:28:3: error: no matching function for call to 'test'
  ASSERT_FALSE(fw == nullptr);
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian-fullbuild/libc-x86_64-debian-fullbuild-dbg-asan/llvm-project/libc/test/UnitTest/LibcTest.h:462:27: note: expanded from macro 'ASSERT_FALSE'
#define ASSERT_FALSE(VAL) ASSERT_EQ(VAL, false)
                          ^~~~~~~~~~~~~~~~~~~~~
/home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian-fullbuild/libc-x86_64-debian-fullbuild-dbg-asan/llvm-project/libc/test/UnitTest/LibcTest.h:438:29: note: expanded from macro 'ASSERT_EQ'
#define ASSERT_EQ(LHS, RHS) LIBC_TEST_BINOP_(EQ, LHS, RHS, return)
                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian-fullbuild/libc-x86_64-debian-fullbuild-dbg-asan/llvm-project/libc/test/UnitTest/LibcTest.h:430:26: note: expanded from macro 'LIBC_TEST_BINOP_'
  LIBC_TEST_SCAFFOLDING_(test(LIBC_NAMESPACE::testing::TestCond::COND, LHS,    \
                         ^~~~
/home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian-fullbuild/libc-x86_64-debian-fullbuild-dbg-asan/llvm-project/libc/test/UnitTest/LibcTest.h:423:7: note: expanded from macro 'LIBC_TEST_SCAFFOLDING_'
  if (TEST)                                                                    \
      ^~~~
/home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian-fullbuild/libc-x86_64-debian-fullbuild-dbg-asan/llvm-project/libc/test/UnitTest/LibcTest.h:99:6: note: candidate function template not viable: requires 7 arguments, but 6 were provided
bool test(RunContext *Ctx, TestCond Cond, ValType LHS, ValType RHS,

```

</details>

https://github.com/llvm/llvm-project/pull/143802