[libc-commits] [libc] 1bf4702 - Disable prctl test when building for arm or riscv. (#143627)
via libc-commits
libc-commits at lists.llvm.org
Tue Jun 10 16:18:57 PDT 2025
Author: Amy Huang
Date: 2025-06-10T16:18:53-07:00
New Revision: 1bf4702d2bbaad522886dfbab913a8dd6efe3b85
URL: https://github.com/llvm/llvm-project/commit/1bf4702d2bbaad522886dfbab913a8dd6efe3b85
DIFF: https://github.com/llvm/llvm-project/commit/1bf4702d2bbaad522886dfbab913a8dd6efe3b85.diff
LOG: Disable prctl test when building for arm or riscv. (#143627)
I'm setting up a buildbot for arm32 using qemu and qemu doesn't support
PR_GET_THP_DISABLE.
Disable the test for now while we figure out what to do about that.
Also disable for riscv because we may do the same for riscv buildbots.
Added:
Modified:
libc/test/src/sys/prctl/linux/CMakeLists.txt
libc/test/src/sys/prctl/linux/prctl_test.cpp
Removed:
################################################################################
diff --git a/libc/test/src/sys/prctl/linux/CMakeLists.txt b/libc/test/src/sys/prctl/linux/CMakeLists.txt
index b06e1c8087008..d02900e1857a0 100644
--- a/libc/test/src/sys/prctl/linux/CMakeLists.txt
+++ b/libc/test/src/sys/prctl/linux/CMakeLists.txt
@@ -1,5 +1,10 @@
add_custom_target(libc_sys_prctl_unittests)
+# Temporarily disable this test while setting up arm and riscv buildbots
+# using qemu, since PR_GET_THP_DISABLE is not supported on qemu.
+if (NOT (LIBC_TARGET_ARCHITECTURE_IS_ARM OR
+ LIBC_TARGET_ARCHITECTURE_IS_RISCV32 OR
+ LIBC_TARGET_ARCHITECTURE_IS_RISCV64))
add_libc_unittest(
prctl_test
SUITE
@@ -13,3 +18,4 @@ add_libc_unittest(
libc.test.UnitTest.ErrnoCheckingTest
libc.test.UnitTest.ErrnoSetterMatcher
)
+endif()
diff --git a/libc/test/src/sys/prctl/linux/prctl_test.cpp b/libc/test/src/sys/prctl/linux/prctl_test.cpp
index 374c905e0ef8a..76b829c82d1be 100644
--- a/libc/test/src/sys/prctl/linux/prctl_test.cpp
+++ b/libc/test/src/sys/prctl/linux/prctl_test.cpp
@@ -34,6 +34,7 @@ TEST_F(LlvmLibcSysPrctlTest, GetSetName) {
TEST_F(LlvmLibcSysPrctlTest, GetTHPDisable) {
// Manually check errno since the return value logic here is not
// covered in ErrnoSetterMatcher.
+ // Note that PR_GET_THP_DISABLE is not supported by QEMU.
int ret = LIBC_NAMESPACE::prctl(PR_GET_THP_DISABLE, 0, 0, 0, 0);
ASSERT_ERRNO_SUCCESS();
// PR_GET_THP_DISABLE return (as the function result) the current
More information about the libc-commits
mailing list