[libc-commits] [libc] [llvm] [libc][math] Refactor asin implementation to header-only in src/__support/math folder. (PR #148578)

[via libc-commits]

lntue wrote:

> Hi there, we are seeing libc build errors in our bots likely related to this PR. Could you take a look and fix it? Thanks!
> 
> > FAILED: libc/src/math/generic/CMakeFiles/libc.src.math.generic.asin.dir/asin.cpp.o
> > /home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.build/./bin/clang++ --target=amdgcn-amd-amdhsa -DLIBC_NAMESPACE=__llvm_libc_22_0_0_git -D__LIBC_USE_FLOAT16_CONVERSION -I/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/libc -isystem /home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.build/include/amdgcn-amd-amdhsa -O3 -DNDEBUG --target=amdgcn-amd-amdhsa -D__LIBC_USE_BUILTIN_CEIL_FLOOR_RINT_TRUNC -D__LIBC_USE_BUILTIN_ROUND -D__LIBC_USE_BUILTIN_ROUNDEVEN -DLIBC_QSORT_IMPL=LIBC_QSORT_QUICK_SORT -DLIBC_ADD_NULL_CHECKS "-DLIBC_MATH=(LIBC_MATH_SKIP_ACCURATE_PASS | LIBC_MATH_SMALL_TABLES | LIBC_MATH_NO_ERRNO | LIBC_MATH_NO_EXCEPT)" -DLIBC_ERRNO_MODE=LIBC_ERRNO_MODE_SHARED -fpie -DLIBC_FULL_BUILD -nostdlibinc -ffixed-point -fno-exceptions -fno-lax-vector-conversions -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-rtti -ftrivial-auto-var-init=pattern -fno-omit-frame-pointer -Wall -Wextra -Werror -Wconversion -Wno-sign-conversion -Wdeprecated -Wno-c99-extensions -Wno-gnu-imaginary-constant -Wno-pedantic -Wimplicit-fallthrough -Wwrite-strings -Wextra-semi -Wnewline-eof -Wnonportable-system-include-path -Wstrict-prototypes -Wthread-safety -Wglobal-constructors -nogpulib -fvisibility=hidden -fconvergent-functions -flto -Wno-multi-gpu -Xclang -mcode-object-version=none -DLIBC_COPT_PUBLIC_PACKAGING -UNDEBUG -MD -MT libc/src/math/generic/CMakeFiles/libc.src.math.generic.asin.dir/asin.cpp.o -MF libc/src/math/generic/CMakeFiles/libc.src.math.generic.asin.dir/asin.cpp.o.d -o libc/src/math/generic/CMakeFiles/libc.src.math.generic.asin.dir/asin.cpp.o -c /home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/libc/src/math/generic/asin.cpp
> > In file included from /home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/libc/src/math/generic/asin.cpp:10:
> > /home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/libc/src/__support/math/asin.h:30:9: error: unused type alias 'Float128' [-Werror,-Wunused-local-typedef]
> > 30 |   using Float128 = fputil::DyadicFloat<128>;
> > |         ^
> > /home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/libc/src/__support/math/asin.h:31:9: error: unused type alias 'DoubleDouble' [-Werror,-Wunused-local-typedef]
> > 31 |   using DoubleDouble = fputil::DoubleDouble;
> > |         ^
> > 2 errors generated.
> 
> bot: https://lab.llvm.org/buildbot/#/builders/10/builds/10213

It should be fixed with https://github.com/llvm/llvm-project/pull/150726

https://github.com/llvm/llvm-project/pull/148578