[libc-commits] [libc] [llvm] [libc] wcslcat implementation (PR #146588)

[Michael Jones via libc-commits]

================
@@ -0,0 +1,39 @@
+//===-- Implementation of wcslcat -----------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "src/wchar/wcslcat.h"
+
+#include "hdr/types/size_t.h"
+#include "hdr/types/wchar_t.h"
+#include "src/__support/common.h"
+#include "src/__support/macros/config.h"
+#include "src/string/string_utils.h"
+
+namespace LIBC_NAMESPACE_DECL {
+
+LLVM_LIBC_FUNCTION(size_t, wcslcat,
+                   (wchar_t *__restrict dst, const wchar_t *__restrict src,
+                    size_t dstsize)) {
+  size_t dstlen = internal::string_length(dst);
+  size_t srclen = internal::string_length(src);
+  size_t limit = dstsize - dstlen - 1;
+
+  if (static_cast<int>(limit) < 0)
+    return (dstsize < dstlen ? dstsize : dstlen) + srclen;
+  size_t i = 0;
+  for (; i < limit && src[i] != L'\0'; ++i) {
+    dst[dstlen + i] = src[i];
+  }
+
+  // appending null terminator if there is room
+  if (dstlen + i < dstlen + dstsize)
+    dst[dstlen + i] = L'\0';
+  return (dstsize < dstlen ? dstsize : dstlen) + srclen;
----------------
michaelrj-google wrote:

this ternary is used in two places, you should make it a variable and name it.

https://github.com/llvm/llvm-project/pull/146588