[libc-commits] [libc] [libc] implement `sys/uio/readv` (PR #124718)

Nick Desaulniers via libc-commits libc-commits at lists.llvm.org
Tue Jan 28 09:08:22 PST 2025


================
@@ -0,0 +1,27 @@
+//===-- Implementation file for readv -------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+#include "src/sys/uio/readv.h"
+#include "src/__support/OSUtil/syscall.h"
+#include "src/__support/common.h"
+#include "src/errno/libc_errno.h"
----------------
nickdesaulniers wrote:

We should add explicit includes for `ssize_t` and `iovec`, even though they are in the readv.h header. (IWYU 1000%).

```suggestion
#include "src/errno/libc_errno.h"
#include "hdr/types/ssize_t.h"
#include "hdr/types/struct_iovec.h"
```
(but sort the result).

https://github.com/llvm/llvm-project/pull/124718


More information about the libc-commits mailing list