[libc-commits] [libc] [libc]: Clean up unnecessary function pointers in scanf (PR #121215)

Michael Jones via libc-commits libc-commits at lists.llvm.org
Thu Jan 23 10:30:41 PST 2025


================
@@ -9,15 +9,73 @@
 #ifndef LLVM_LIBC_SRC_STDIO_SCANF_CORE_READER_H
 #define LLVM_LIBC_SRC_STDIO_SCANF_CORE_READER_H
 
+// has the macro subsitution failure
+// #ifdef LIBC_FULL_BUILD
+#include "src/__support/File/file.h"
----------------
michaelrj-google wrote:

you just need to add an `#ifndef LIBC_COPT_STDIO_USE_SYSTEM_FILE` around `#include "src/__support/File/file.h"`, so that it it's only included when we're not using the system's file. You'll need to add a similar check in the cmake so that `libc.src.__support.File.file` is only a listed dependency when in fullbuild.

https://github.com/llvm/llvm-project/pull/121215


More information about the libc-commits mailing list