[libc-commits] [libc] [libc] Use `${libc_opt_high_flag}` instead of `-O3` (PR #123233)

Petr Hosek via libc-commits libc-commits at lists.llvm.org
Fri Jan 17 10:24:38 PST 2025


================
@@ -534,7 +534,7 @@ add_entrypoint_object(
     libc.src.__support.macros.optimization
     libc.src.__support.macros.properties.types
   COMPILE_OPTIONS
-    -O3
+    ${libc_opt_high_flag}
----------------
petrhosek wrote:

I agree, I plan to remove all of these explicit flags in a follow up patch once we have a bot set up. This change was supposed to be just an NFC cleanup,  but as you can see in https://github.com/llvm/llvm-project/pull/123233#issuecomment-2598945824, it already uncovered an issue to how we handle flags on Windows.

https://github.com/llvm/llvm-project/pull/123233


More information about the libc-commits mailing list