[libc-commits] [libc] [libc][math] Improve the performance of sqrtf128. (PR #122578)

[Nick Desaulniers via libc-commits]

================
@@ -1,20 +1,355 @@
 //===-- Implementation of sqrtf128 function -------------------------------===//
 //
+// Copyright (c) 2024 Alexei Sibidanov <sibid at uvic.ca>
----------------
nickdesaulniers wrote:

These are generally frowned upon, since they cannot be removed.

https://llvm.org/docs/DeveloperPolicy.html#new-llvm-project-license-framework

> You cannot strip the copyright headers off or replace them with your own.

I've spoken with company lawyers about these copyright assignments previously (not in regards to this patch), and they've echo'd the above sentiment.

It also makes it very difficult to refactor code in the future.  Let's say we split this file in two. Do we copy over the attribution or not?  It gets complicated.  Please do not introduce such complication into libc/.

I think https://llvm.org/docs/DeveloperPolicy.html#copyright also addresses this:

> the copyright for the code in the project is held by the respective contributors.

I'm going to throw a "minus one" on this patch until this is dropped.  If necessary, I can reach out to LLVM's board to get more precise language around copyright attribution in comments added to https://llvm.org/docs/DeveloperPolicy.html.

https://github.com/llvm/llvm-project/pull/122578