[libc-commits] [libc] [libc][NFC] Cleanup time.h (PR #122027)

Nick Desaulniers via libc-commits libc-commits at lists.llvm.org
Wed Jan 8 10:36:58 PST 2025


================
@@ -14,15 +14,13 @@
 
 namespace LIBC_NAMESPACE_DECL {
 
-using LIBC_NAMESPACE::time_utils::TimeConstants;
-
 LLVM_LIBC_FUNCTION(char *, ctime, (const time_t *t_ptr)) {
   if (t_ptr == nullptr || *t_ptr > cpp::numeric_limits<int32_t>::max()) {
     return nullptr;
   }
-  static char buffer[TimeConstants::ASCTIME_BUFFER_SIZE];
+  static char buffer[time_constants::ASCTIME_BUFFER_SIZE];
----------------
nickdesaulniers wrote:

In the vain of IWYU, should this TU explicitly include "src/time/time_constants.h"?  Here and below.

https://github.com/llvm/llvm-project/pull/122027


More information about the libc-commits mailing list