[libc-commits] [libc] [libc]: Clean up unnecessary function pointers in scanf (PR #121215)

Michael Jones via libc-commits libc-commits at lists.llvm.org
Mon Jan 6 13:46:39 PST 2025


================
@@ -62,6 +62,7 @@ add_object_library(
     reader.h
   DEPENDS
     libc.src.__support.macros.attributes
+    libc.hdr.types.FILE
----------------
michaelrj-google wrote:

This is missing the dependency on `libc.src.__support.File.file`, as well as the flag controlling if it's using the system file. You'll also need to set up proper handling for the GPU like what `vfscanf_internal` has.
```suggestion
    libc.src.__support.File.file
    libc.hdr.types.FILE
  ${use_system_file}
```

https://github.com/llvm/llvm-project/pull/121215


More information about the libc-commits mailing list