[libc-commits] [libc] [libc] Make two include/llvm-libc-types/ headers more self-contained. (PR #128094)

Alexey Samsonov via libc-commits libc-commits at lists.llvm.org
Thu Feb 20 21:58:27 PST 2025


================
@@ -11,7 +11,6 @@
 
 #include "__llvm-libc-common.h"
 #include "llvm-libc-macros/inttypes-macros.h"
-#include <stdint.h>
----------------
vonosmas wrote:

In this specific case though, helpful hdrgen already inserts `#include <stdint.h>` statement to the generated header: because `intmax_t` is among the types returned by the functions in `inttypes.h.def`. See:
https://github.com/llvm/llvm-project/blob/fd5d1cbb75e4278d9074ff105efd3ab48f778b4b/libc/utils/hdrgen/header.py#L31

Given that, is it OK to still remove this explicit include?

https://github.com/llvm/llvm-project/pull/128094


More information about the libc-commits mailing list