[libc-commits] [libc] [libc] Additional check for File support in scanf_core (PR #128079)
Michael Jones via libc-commits
libc-commits at lists.llvm.org
Thu Feb 20 14:45:42 PST 2025
michaelrj-google wrote:
> > > > I'm not sure if this will work for baremetal, since right now the fscanf scanner requires either the system's FILE or our own FILE. We might need to add a hook similar to what's in https://github.com/llvm/llvm-project/blob/main/libc/src/stdio/baremetal/printf.cpp, or alternately just add baremetal versions of `getc` and `ungetc`
> > >
> > >
> > > I have a WIP implementation of that locally, I'll clean it up and send it for review.
> >
> >
> > Would it make sense to turn off `scanf` on baremetal temporarily to unbreak the bots then?
>
> It's not included in any of the baremetal `entrypoints.txt` files so I'm not sure why it's being pulled in.
Ah, in that case this might fix the build. These aren't entrypoints so they're being built unconditionally, and if nothing is providing `getc`, `ungetc`, and `ferror` they should fail to link, but if nothing tries to link them it might just pass.
https://github.com/llvm/llvm-project/pull/128079
More information about the libc-commits
mailing list