[libc-commits] [libc] Enable -Wconversion (PR #127523)

Vinay Deshmukh via libc-commits libc-commits at lists.llvm.org
Mon Feb 17 09:10:19 PST 2025


https://github.com/vinay-deshmukh created https://github.com/llvm/llvm-project/pull/127523

Relates to: #119281 

>From 338a9c070c390c5b9ff05777750510166919f308 Mon Sep 17 00:00:00 2001
From: Vinay Deshmukh <32487576+vinay-deshmukh at users.noreply.github.com>
Date: Mon, 17 Feb 2025 12:07:47 -0500
Subject: [PATCH] Enable -Wconversion

---
 libc/cmake/modules/LLVMLibCTestRules.cmake | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libc/cmake/modules/LLVMLibCTestRules.cmake b/libc/cmake/modules/LLVMLibCTestRules.cmake
index f33db5826537b..75eb1a06332ac 100644
--- a/libc/cmake/modules/LLVMLibCTestRules.cmake
+++ b/libc/cmake/modules/LLVMLibCTestRules.cmake
@@ -36,7 +36,7 @@ function(_get_common_test_compile_options output_var c_test flags)
     if(NOT LIBC_WNO_ERROR)
       # list(APPEND compile_options "-Werror")
     endif()
-    # list(APPEND compile_options "-Wconversion")
+    list(APPEND compile_options "-Wconversion")
     # list(APPEND compile_options "-Wno-sign-conversion")
     list(APPEND compile_options "-Wimplicit-fallthrough")
     list(APPEND compile_options "-Wwrite-strings")



More information about the libc-commits mailing list