[libc-commits] [libc] b0d7820 - [libc] Move __LLVM_LIBC__ define to __llvm-libc-common.h (#126877)

[via libc-commits]

Author: Petr Hosek
Date: 2025-02-12T11:37:07-08:00
New Revision: b0d782080529cf5d422847e1f91f29bd7c62f691

URL: https://github.com/llvm/llvm-project/commit/b0d782080529cf5d422847e1f91f29bd7c62f691
DIFF: https://github.com/llvm/llvm-project/commit/b0d782080529cf5d422847e1f91f29bd7c62f691.diff

LOG: [libc] Move __LLVM_LIBC__ define to __llvm-libc-common.h (#126877)

Relying on features.h is problematic since codebases are free to have
such a header on their search path, which breaks compilation. libc
should instead provide a more standard way of getting __LLVM_LIBC__.
Since __llvm-libc-common.h is included from all libc headers, defining
__LLVM_LIBC__ there ensures that this define is available whenever any
of the standard header is included.

Added: 
    

Modified: 
    libc/include/__llvm-libc-common.h
    libc/include/llvm-libc-macros/features-macros.h

Removed: 
    


################################################################################
diff  --git a/libc/include/__llvm-libc-common.h b/libc/include/__llvm-libc-common.h
index d3f8a4e63268a..a0fa506c01ab8 100644
--- a/libc/include/__llvm-libc-common.h
+++ b/libc/include/__llvm-libc-common.h
@@ -9,6 +9,8 @@
 #ifndef LLVM_LIBC_COMMON_H
 #define LLVM_LIBC_COMMON_H
 
+#define __LLVM_LIBC__ 1
+
 #ifdef __cplusplus
 
 #undef __BEGIN_C_DECLS

diff  --git a/libc/include/llvm-libc-macros/features-macros.h b/libc/include/llvm-libc-macros/features-macros.h
index 5bc87a68fc0ba..f87ae4ad12408 100644
--- a/libc/include/llvm-libc-macros/features-macros.h
+++ b/libc/include/llvm-libc-macros/features-macros.h
@@ -9,6 +9,4 @@
 #ifndef LLVM_LIBC_MACROS_FEATURES_MACROS_H
 #define LLVM_LIBC_MACROS_FEATURES_MACROS_H
 
-#define __LLVM_LIBC__ 1
-
 #endif // LLVM_LIBC_MACROS_FEATURES_MACROS_H