[libc-commits] [libc] [libc] Expand usage of libc null checks. (PR #116262)

Nick Desaulniers via libc-commits libc-commits at lists.llvm.org
Mon Feb 10 10:58:33 PST 2025


================
@@ -374,7 +383,7 @@ add_libc_test(
     libc.src.string.memset_explicit
 )
 
-add_libc_multi_impl_test(memcmp libc-string-tests SRCS memcmp_test.cpp)
+add_libc_multi_impl_test(memcmp UNIT_TEST_ONLY libc-string-tests SRCS memcmp_test.cpp)
----------------
nickdesaulniers wrote:

> Any explanation as to why it won't compile when added in a TEST but will compile when in a TEST_F

I was not aware of that requirement. Nothing obvious to me, perhaps @michaelrj-google or @lntue know.

> ninja libc libm check-libc is this the correct way to simulate a full build test run locally ?

`ninja libc-unit-tests`

https://github.com/llvm/llvm-project/pull/116262


More information about the libc-commits mailing list