[libc-commits] [libc] [libc] init uefi os target (PR #120687)

Petr Hosek via libc-commits libc-commits at lists.llvm.org
Sat Feb 8 13:23:48 PST 2025


petrhosek wrote:

> This is a beast of a patch, would probably be easier if we just enabled the minimal set of entrypoints necessary to run tests and then added everything else.

I agree, I started reviewing this change but it's too big to review in its entirety, especially as the implementation keeps evolving. There are also several parts of this change that I think will require further discussion (preferably on Discourse or at LLVM libc monthly meeting), and some might require further changes to the Clang driver.

I would suggest breaking up this change into a series of smaller PRs which is a good software engineering practice. The first PR would ideally be just the minimal build support necessary to build an empty C program (this is actually what the description of this PR says but the actual implementation is much larger). Every feature should then have its own PR, the smaller the better.

https://github.com/llvm/llvm-project/pull/120687


More information about the libc-commits mailing list