[libc-commits] [libc] [libc][stdfix] Implement fixed point `countlsfx` functions in llvm-libc (PR #125356)

LLVM Continuous Integration via libc-commits libc-commits at lists.llvm.org
Fri Feb 7 20:22:29 PST 2025 

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `premerge-monolithic-linux` running on `premerge-linux-1` while building `libc` at step 6 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/153/builds/22295

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 6 (build-unified-tree) failure: build (failure)
...
6.674 [977/58/546] Building CXX object libc/src/stdbit/CMakeFiles/libc.src.stdbit.stdc_first_trailing_one_uc.dir/stdc_first_trailing_one_uc.cpp.o
6.674 [976/58/547] Building CXX object libc/src/stdbit/CMakeFiles/libc.src.stdbit.stdc_first_trailing_one_us.dir/stdc_first_trailing_one_us.cpp.o
6.675 [975/58/548] Building CXX object libc/src/stdbit/CMakeFiles/libc.src.stdbit.stdc_first_trailing_one_ui.dir/stdc_first_trailing_one_ui.cpp.o
6.675 [974/58/549] Building CXX object libc/src/stdbit/CMakeFiles/libc.src.stdbit.stdc_first_trailing_one_ul.dir/stdc_first_trailing_one_ul.cpp.o
6.676 [973/58/550] Building CXX object libc/src/stdbit/CMakeFiles/libc.src.stdbit.stdc_first_trailing_one_ull.dir/stdc_first_trailing_one_ull.cpp.o
6.676 [972/58/551] Building CXX object libc/src/stdbit/CMakeFiles/libc.src.stdbit.stdc_count_zeros_us.dir/stdc_count_zeros_us.cpp.o
6.676 [971/58/552] Building CXX object libc/src/stdbit/CMakeFiles/libc.src.stdbit.stdc_count_zeros_ui.dir/stdc_count_zeros_ui.cpp.o
6.677 [970/58/553] Building CXX object libc/src/stdbit/CMakeFiles/libc.src.stdbit.stdc_count_zeros_ul.dir/stdc_count_zeros_ul.cpp.o
6.678 [969/58/554] Building CXX object libc/src/stdbit/CMakeFiles/libc.src.stdbit.stdc_count_zeros_ull.dir/stdc_count_zeros_ull.cpp.o
6.678 [968/58/555] Building CXX object libc/src/stdfix/CMakeFiles/libc.src.stdfix.abshr.dir/abshr.cpp.o
FAILED: libc/src/stdfix/CMakeFiles/libc.src.stdfix.abshr.dir/abshr.cpp.o 
/build/buildbot/premerge-monolithic-linux/build/./bin/clang++ --target=x86_64-unknown-linux-gnu -DLIBC_NAMESPACE=__llvm_libc_21_0_0_git -I/build/buildbot/premerge-monolithic-linux/llvm-project/libc -isystem /build/buildbot/premerge-monolithic-linux/build/runtimes/runtimes-bins/libc/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -DLIBC_QSORT_IMPL=LIBC_QSORT_QUICK_SORT -DLIBC_ADD_NULL_CHECKS -fpie -ffixed-point -fno-builtin -fno-exceptions -fno-lax-vector-conversions -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-rtti -ftrivial-auto-var-init=pattern -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -Wall -Wextra -Werror -Wconversion -Wno-sign-conversion -Wdeprecated -Wno-c99-extensions -Wno-gnu-imaginary-constant -Wno-pedantic -Wimplicit-fallthrough -Wwrite-strings -Wextra-semi -Wnewline-eof -Wnonportable-system-include-path -Wstrict-prototypes -Wthread-safety -Wglobal-constructors -O3 -DLIBC_COPT_PUBLIC_PACKAGING -UNDEBUG -std=gnu++17 -MD -MT libc/src/stdfix/CMakeFiles/libc.src.stdfix.abshr.dir/abshr.cpp.o -MF libc/src/stdfix/CMakeFiles/libc.src.stdfix.abshr.dir/abshr.cpp.o.d -o libc/src/stdfix/CMakeFiles/libc.src.stdfix.abshr.dir/abshr.cpp.o -c /build/buildbot/premerge-monolithic-linux/llvm-project/libc/src/stdfix/abshr.cpp
In file included from /build/buildbot/premerge-monolithic-linux/llvm-project/libc/src/stdfix/abshr.cpp:11:
/build/buildbot/premerge-monolithic-linux/llvm-project/libc/src/__support/fixed_point/fx_bits.h:191:9: error: use of undeclared identifier 'x'
  191 |     if (x < 0)
      |         ^
/build/buildbot/premerge-monolithic-linux/llvm-project/libc/src/__support/fixed_point/fx_bits.h:192:7: error: use of undeclared identifier 'x'
  192 |       x = bit_not(x);
      |       ^
/build/buildbot/premerge-monolithic-linux/llvm-project/libc/src/__support/fixed_point/fx_bits.h:192:19: error: use of undeclared identifier 'x'
  192 |       x = bit_not(x);
      |                   ^
/build/buildbot/premerge-monolithic-linux/llvm-project/libc/src/__support/fixed_point/fx_bits.h:195:31: error: use of undeclared identifier 'x'
  195 |   BitType value_bits = FXBits(x)::get_bits();
      |                               ^
/build/buildbot/premerge-monolithic-linux/llvm-project/libc/src/__support/fixed_point/fx_bits.h:195:33: error: expected ';' at end of declaration
  195 |   BitType value_bits = FXBits(x)::get_bits();
      |                                 ^
      |                                 ;
/build/buildbot/premerge-monolithic-linux/llvm-project/libc/src/__support/fixed_point/fx_bits.h:182:11: error: unused parameter 'f' [-Werror,-Wunused-parameter]
  182 | countls(T f) {
      |           ^
6 errors generated.
6.678 [968/57/556] Building CXX object libc/src/stdfix/CMakeFiles/libc.src.stdfix.sqrtuhr.dir/sqrtuhr.cpp.o
6.679 [968/56/557] Building CXX object libc/src/stdfix/CMakeFiles/libc.src.stdfix.sqrtur.dir/sqrtur.cpp.o
6.679 [968/55/558] Building CXX object libc/src/stdfix/CMakeFiles/libc.src.stdfix.sqrtulr.dir/sqrtulr.cpp.o
6.679 [968/54/559] Building CXX object libc/src/stdfix/CMakeFiles/libc.src.stdfix.sqrtuhk.dir/sqrtuhk.cpp.o
6.679 [968/53/560] Building CXX object libc/src/stdfix/CMakeFiles/libc.src.stdfix.sqrtuk.dir/sqrtuk.cpp.o
6.679 [968/52/561] Building CXX object libc/src/stdfix/CMakeFiles/libc.src.stdfix.roundhr.dir/roundhr.cpp.o
FAILED: libc/src/stdfix/CMakeFiles/libc.src.stdfix.roundhr.dir/roundhr.cpp.o 
/build/buildbot/premerge-monolithic-linux/build/./bin/clang++ --target=x86_64-unknown-linux-gnu -DLIBC_NAMESPACE=__llvm_libc_21_0_0_git -I/build/buildbot/premerge-monolithic-linux/llvm-project/libc -isystem /build/buildbot/premerge-monolithic-linux/build/runtimes/runtimes-bins/libc/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -DLIBC_QSORT_IMPL=LIBC_QSORT_QUICK_SORT -DLIBC_ADD_NULL_CHECKS -fpie -ffixed-point -fno-builtin -fno-exceptions -fno-lax-vector-conversions -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-rtti -ftrivial-auto-var-init=pattern -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -Wall -Wextra -Werror -Wconversion -Wno-sign-conversion -Wdeprecated -Wno-c99-extensions -Wno-gnu-imaginary-constant -Wno-pedantic -Wimplicit-fallthrough -Wwrite-strings -Wextra-semi -Wnewline-eof -Wnonportable-system-include-path -Wstrict-prototypes -Wthread-safety -Wglobal-constructors -O3 -DLIBC_COPT_PUBLIC_PACKAGING -UNDEBUG -std=gnu++17 -MD -MT libc/src/stdfix/CMakeFiles/libc.src.stdfix.roundhr.dir/roundhr.cpp.o -MF libc/src/stdfix/CMakeFiles/libc.src.stdfix.roundhr.dir/roundhr.cpp.o.d -o libc/src/stdfix/CMakeFiles/libc.src.stdfix.roundhr.dir/roundhr.cpp.o -c /build/buildbot/premerge-monolithic-linux/llvm-project/libc/src/stdfix/roundhr.cpp
In file included from /build/buildbot/premerge-monolithic-linux/llvm-project/libc/src/stdfix/roundhr.cpp:11:
/build/buildbot/premerge-monolithic-linux/llvm-project/libc/src/__support/fixed_point/fx_bits.h:191:9: error: use of undeclared identifier 'x'
  191 |     if (x < 0)
      |         ^
/build/buildbot/premerge-monolithic-linux/llvm-project/libc/src/__support/fixed_point/fx_bits.h:192:7: error: use of undeclared identifier 'x'
  192 |       x = bit_not(x);
      |       ^
/build/buildbot/premerge-monolithic-linux/llvm-project/libc/src/__support/fixed_point/fx_bits.h:192:19: error: use of undeclared identifier 'x'

```

</details>

https://github.com/llvm/llvm-project/pull/125356

More information about the libc-commits mailing list