[libc-commits] [libc] [libc] Expand usage of libc null checks. (PR #116262)
Nick Desaulniers via libc-commits
libc-commits at lists.llvm.org
Fri Feb 7 13:11:06 PST 2025
================
@@ -374,7 +383,7 @@ add_libc_test(
libc.src.string.memset_explicit
)
-add_libc_multi_impl_test(memcmp libc-string-tests SRCS memcmp_test.cpp)
+add_libc_multi_impl_test(memcmp UNIT_TEST_ONLY libc-string-tests SRCS memcmp_test.cpp)
----------------
nickdesaulniers wrote:
Hmmm...right so the question is one of test coverage.
Improving test coverage is always nice. Rather than disabling our tests (including important behavior tests the test functionality other than this trapping additions) outright for !linux and !hermetic test, we should instead change the ifdefs in the tests to check for `LIBC_FULL_BUILD` IMO.
https://github.com/llvm/llvm-project/pull/116262
More information about the libc-commits
mailing list