[libc-commits] [libc] fix: removes invalid token from LLVM_VERSION_SUFFIX in LIBC namespace (PR #126193)

Joseph Huber via libc-commits libc-commits at lists.llvm.org
Fri Feb 7 07:04:53 PST 2025


================
@@ -51,7 +51,8 @@ set(LIBC_KERNEL_HEADERS "/usr/include" CACHE STRING "Path to Linux kernel header
 # Defining a global namespace to enclose all libc functions.
 set(default_namespace "__llvm_libc")
 if(LLVM_VERSION_MAJOR)
-  set(default_namespace "__llvm_libc_${LLVM_VERSION_MAJOR}_${LLVM_VERSION_MINOR}_${LLVM_VERSION_PATCH}_${LLVM_VERSION_SUFFIX}")
+  string(REPLACE "-" "" NS_LLVM_VERSION_SUFFIX ${LLVM_VERSION_SUFFIX})
----------------
jhuber6 wrote:

Realized that the patch is like `-rc1` so this would end up `__rc1`. So it's probably fine as-is. Easier is just deleting the version suffix, since AFAIK it only applies to release candidates, but I'll leave that to @nickdesaulniers.

https://github.com/llvm/llvm-project/pull/126193


More information about the libc-commits mailing list