[libc-commits] [libc] [libc][signal] clean up usage of sighandler_t (PR #125745)
Nick Desaulniers via libc-commits
libc-commits at lists.llvm.org
Thu Feb 6 13:11:22 PST 2025
================
@@ -10,5 +10,6 @@
#define LLVM_LIBC_TYPES___SIGHANDLER_T_H
typedef void (*__sighandler_t)(int);
----------------
nickdesaulniers wrote:
Perhaps it would be better for me to `#include <linux/signal.h>` from our generated `signal.h` in order to provide `__sighandler_t` (and everything else that entails) such that users don't need to directly+explicitly depend on `<linux/signal.h>`.
It's worth deeper discussions with all of us about policy relating to kernel headers. (https://sourceware.org/glibc/wiki/Synchronizing_Headers comes to mind, but perhaps isn't the only approach as you've mentioned).
But for now, I'm in a sprint to get llvm-libc's test harness to cross compile. The fix is to clean up the usage of `__sighandler_t`, which is the intent of this PR.
https://github.com/llvm/llvm-project/pull/125745
More information about the libc-commits
mailing list