[libc-commits] [libc] [libc][signal] clean up usage of sighandler_t (PR #125745)

via libc-commits libc-commits at lists.llvm.org
Thu Feb 6 07:45:20 PST 2025


================
@@ -10,5 +10,6 @@
 #define LLVM_LIBC_TYPES___SIGHANDLER_T_H
 
 typedef void (*__sighandler_t)(int);
----------------
enh-google wrote:

yeah, that's kind of what i meant: "you probably shouldn't define `__sighandler_t`, and should leave that to the uapi header [which callers can #include directly if they want it]" ... except that "what about all the other stuff?". because bionic doesn't _deliberately_ export `__sighandler_t`; it just gets it because it's in the same uapi header as all the other stuff that we _do_ need to export, and we have a pretty strict [absolute?] rule about "no copy & paste of content that's in a uapi header --- include the uapi header instead".

(technically we do explicitly filter some stuff _out_ of uapi headers, but generally only when they actively cause widespread breakage/pollution if you leave them in.)

https://github.com/llvm/llvm-project/pull/125745


More information about the libc-commits mailing list