[libc-commits] [libc] [libc][cmake] Do not overwrite SKIP_FLAG_EXPANSION_*. (PR #125762)

Petr Hosek via libc-commits libc-commits at lists.llvm.org
Wed Feb 5 22:47:33 PST 2025


petrhosek wrote:

> I thought that's what `FORCE` did for `set` statements?
> 
> https://cmake.org/cmake/help/latest/command/set.html#set-cache-entry
> 
> i.e., if `FORCE` wasn't set, `set` would not re-set a value when it was specified by a user?
> 
> I don't care much either way, but perhaps I misremember what `FORCE` does. Because we don't use `FORCE` for these set statements, I would have thought we already do not overwrite these.
> 
> perhaps @petrhosek can clarify before you land this?

`FORCE` is used to overwrite a cached variable value but that's not what we're trying to do here.

https://github.com/llvm/llvm-project/pull/125762


More information about the libc-commits mailing list