[libc-commits] [libc] [libc][unistd] Implement setsid (PR #125704)
Krishna Pandey via libc-commits
libc-commits at lists.llvm.org
Tue Feb 4 09:26:42 PST 2025
https://github.com/krishna2803 updated https://github.com/llvm/llvm-project/pull/125704
>From 62e0c25c20177eeb7d52865dec54b0cd4b7e15c6 Mon Sep 17 00:00:00 2001
From: krishna2803 <kpandey81930 at gmail.com>
Date: Tue, 4 Feb 2025 21:01:07 +0530
Subject: [PATCH 1/4] feat: implement setsid
---
libc/config/linux/aarch64/entrypoints.txt | 1 +
libc/config/linux/riscv/entrypoints.txt | 1 +
libc/config/linux/x86_64/entrypoints.txt | 1 +
libc/include/unistd.yaml | 6 ++++++
libc/src/unistd/CMakeLists.txt | 7 +++++++
libc/src/unistd/linux/CMakeLists.txt | 14 ++++++++++++++
libc/src/unistd/linux/setsid.cpp | 23 +++++++++++++++++++++++
libc/src/unistd/setsid.h | 22 ++++++++++++++++++++++
libc/test/src/unistd/CMakeLists.txt | 10 ++++++++++
libc/test/src/unistd/setsid_test.cpp | 15 +++++++++++++++
10 files changed, 100 insertions(+)
create mode 100644 libc/src/unistd/linux/setsid.cpp
create mode 100644 libc/src/unistd/setsid.h
create mode 100644 libc/test/src/unistd/setsid_test.cpp
diff --git a/libc/config/linux/aarch64/entrypoints.txt b/libc/config/linux/aarch64/entrypoints.txt
index 09eb51a3f8fc62..49e3c04b0ca16a 100644
--- a/libc/config/linux/aarch64/entrypoints.txt
+++ b/libc/config/linux/aarch64/entrypoints.txt
@@ -341,6 +341,7 @@ set(TARGET_LIBC_ENTRYPOINTS
libc.src.unistd.readlink
libc.src.unistd.readlinkat
libc.src.unistd.rmdir
+ libc.src.unistd.setsid
libc.src.unistd.symlink
libc.src.unistd.symlinkat
libc.src.unistd.sysconf
diff --git a/libc/config/linux/riscv/entrypoints.txt b/libc/config/linux/riscv/entrypoints.txt
index 14a05a2f3fbf2a..4d1d87170208d0 100644
--- a/libc/config/linux/riscv/entrypoints.txt
+++ b/libc/config/linux/riscv/entrypoints.txt
@@ -337,6 +337,7 @@ set(TARGET_LIBC_ENTRYPOINTS
libc.src.unistd.readlink
libc.src.unistd.readlinkat
libc.src.unistd.rmdir
+ libc.src.unistd.setsid
libc.src.unistd.symlink
libc.src.unistd.symlinkat
libc.src.unistd.sysconf
diff --git a/libc/config/linux/x86_64/entrypoints.txt b/libc/config/linux/x86_64/entrypoints.txt
index 366e4d34294d15..c8e0adaeee2827 100644
--- a/libc/config/linux/x86_64/entrypoints.txt
+++ b/libc/config/linux/x86_64/entrypoints.txt
@@ -340,6 +340,7 @@ set(TARGET_LIBC_ENTRYPOINTS
libc.src.unistd.readlink
libc.src.unistd.readlinkat
libc.src.unistd.rmdir
+ libc.src.unistd.setsid
libc.src.unistd.symlink
libc.src.unistd.symlinkat
libc.src.unistd.sysconf
diff --git a/libc/include/unistd.yaml b/libc/include/unistd.yaml
index c1901be446fe5c..d04d46bd5c002a 100644
--- a/libc/include/unistd.yaml
+++ b/libc/include/unistd.yaml
@@ -275,6 +275,12 @@ functions:
- type: const void *__restrict
- type: void *
- type: ssize_t
+ - name: setsid
+ standards:
+ - POSIX
+ return_type: pid_t
+ arguments:
+ - type: void
- name: symlink
standards:
- POSIX
diff --git a/libc/src/unistd/CMakeLists.txt b/libc/src/unistd/CMakeLists.txt
index 6bdea0c7693bd9..fb563ec4ecfd99 100644
--- a/libc/src/unistd/CMakeLists.txt
+++ b/libc/src/unistd/CMakeLists.txt
@@ -231,6 +231,13 @@ add_entrypoint_object(
.${LIBC_TARGET_OS}.rmdir
)
+add_entrypoint_object(
+ setsid
+ ALIAS
+ DEPENDS
+ .${LIBC_TARGET_OS}.setsid
+)
+
add_entrypoint_object(
symlink
ALIAS
diff --git a/libc/src/unistd/linux/CMakeLists.txt b/libc/src/unistd/linux/CMakeLists.txt
index 2bb17f56f7b32e..88db28acbaeb90 100644
--- a/libc/src/unistd/linux/CMakeLists.txt
+++ b/libc/src/unistd/linux/CMakeLists.txt
@@ -459,6 +459,20 @@ add_entrypoint_object(
libc.src.errno.errno
)
+add_entrypoint_object(
+ setsid
+ SRCS
+ setsid.cpp
+ HDRS
+ ../setsid.h
+ DEPENDS
+ libc.hdr.types.pid_t
+ libc.hdr.fcntl_macros
+ libc.include.unistd
+ libc.include.sys_syscall
+ libc.src.__support.OSUtil.osutil
+)
+
add_entrypoint_object(
symlink
SRCS
diff --git a/libc/src/unistd/linux/setsid.cpp b/libc/src/unistd/linux/setsid.cpp
new file mode 100644
index 00000000000000..d504ab3aba3ac9
--- /dev/null
+++ b/libc/src/unistd/linux/setsid.cpp
@@ -0,0 +1,23 @@
+//===-- Linux implementation of setsid --------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "src/unistd/setsid.h"
+
+#include "src/__support/OSUtil/syscall.h" // For internal syscall function.
+#include "src/__support/common.h"
+#include "src/__support/macros/config.h"
+
+#include <sys/syscall.h> // For syscall numbers.
+
+namespace LIBC_NAMESPACE_DECL {
+
+LLVM_LIBC_FUNCTION(pid_t, setsid, ()) {
+ return LIBC_NAMESPACE::syscall_impl<pid_t>(SYS_setsid);
+}
+
+} // namespace LIBC_NAMESPACE_DECL
diff --git a/libc/src/unistd/setsid.h b/libc/src/unistd/setsid.h
new file mode 100644
index 00000000000000..7f40cb84de300b
--- /dev/null
+++ b/libc/src/unistd/setsid.h
@@ -0,0 +1,22 @@
+//===-- Implementation header for setsid ------------------------*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef LLVM_LIBC_SRC_UNISTD_GETPID_H
+#define LLVM_LIBC_SRC_UNISTD_GETPID_H
+
+#include "hdr/types/pid_t.h"
+#include "hdr/unistd_macros.h"
+#include "src/__support/macros/config.h"
+
+namespace LIBC_NAMESPACE_DECL {
+
+pid_t setsid();
+
+} // namespace LIBC_NAMESPACE_DECL
+
+#endif // LLVM_LIBC_SRC_UNISTD_GETPID_H
diff --git a/libc/test/src/unistd/CMakeLists.txt b/libc/test/src/unistd/CMakeLists.txt
index b01cce931a1ebf..61142da1ba89fe 100644
--- a/libc/test/src/unistd/CMakeLists.txt
+++ b/libc/test/src/unistd/CMakeLists.txt
@@ -287,6 +287,16 @@ add_libc_unittest(
libc.src.__support.CPP.string_view
)
+add_libc_unittest(
+ setsid_test
+ SUITE
+ libc_unistd_unittests
+ SRCS
+ getpid_test.cpp
+ DEPENDS
+ libc.src.unistd.setsid
+)
+
add_libc_unittest(
symlink_test
SUITE
diff --git a/libc/test/src/unistd/setsid_test.cpp b/libc/test/src/unistd/setsid_test.cpp
new file mode 100644
index 00000000000000..466faa16ea1eb6
--- /dev/null
+++ b/libc/test/src/unistd/setsid_test.cpp
@@ -0,0 +1,15 @@
+//===-- Unittests for setsid ----------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "src/unistd/setsid.h"
+#include "test/UnitTest/Test.h"
+
+TEST(LlvmLibcGetPidTest, SmokeTest) {
+ // setsid always succeeds. So, we just call it as a smoke test.
+ LIBC_NAMESPACE::setsid();
+}
>From c917d11a106b3c71b70a333cf97acd5036c140a5 Mon Sep 17 00:00:00 2001
From: krishna2803 <kpandey81930 at gmail.com>
Date: Tue, 4 Feb 2025 21:02:56 +0530
Subject: [PATCH 2/4] nit: clang-format
---
libc/src/unistd/linux/setsid.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libc/src/unistd/linux/setsid.cpp b/libc/src/unistd/linux/setsid.cpp
index d504ab3aba3ac9..9ed7307ab89829 100644
--- a/libc/src/unistd/linux/setsid.cpp
+++ b/libc/src/unistd/linux/setsid.cpp
@@ -1,4 +1,4 @@
-//===-- Linux implementation of setsid --------------------------------------------===//
+//===-- Linux implementation of setsid-------------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
>From 2f0d16ecc4865146fe0a5a907a9828b5c1dcac4f Mon Sep 17 00:00:00 2001
From: krishna2803 <kpandey81930 at gmail.com>
Date: Tue, 4 Feb 2025 21:06:41 +0530
Subject: [PATCH 3/4] fix: typo change getpid to setsid
---
libc/test/src/unistd/CMakeLists.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libc/test/src/unistd/CMakeLists.txt b/libc/test/src/unistd/CMakeLists.txt
index 61142da1ba89fe..665cb367ba4fdd 100644
--- a/libc/test/src/unistd/CMakeLists.txt
+++ b/libc/test/src/unistd/CMakeLists.txt
@@ -292,7 +292,7 @@ add_libc_unittest(
SUITE
libc_unistd_unittests
SRCS
- getpid_test.cpp
+ setsid_test.cpp
DEPENDS
libc.src.unistd.setsid
)
>From 52a98bbcac609fc164fb3e068b47cf3b11a35858 Mon Sep 17 00:00:00 2001
From: krishna2803 <kpandey81930 at gmail.com>
Date: Tue, 4 Feb 2025 22:55:18 +0530
Subject: [PATCH 4/4] nit: remove redundant includes
---
libc/src/unistd/linux/CMakeLists.txt | 2 --
libc/src/unistd/linux/setsid.cpp | 1 +
libc/src/unistd/setsid.h | 1 -
3 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/libc/src/unistd/linux/CMakeLists.txt b/libc/src/unistd/linux/CMakeLists.txt
index 88db28acbaeb90..afdc595d0b26fe 100644
--- a/libc/src/unistd/linux/CMakeLists.txt
+++ b/libc/src/unistd/linux/CMakeLists.txt
@@ -467,8 +467,6 @@ add_entrypoint_object(
../setsid.h
DEPENDS
libc.hdr.types.pid_t
- libc.hdr.fcntl_macros
- libc.include.unistd
libc.include.sys_syscall
libc.src.__support.OSUtil.osutil
)
diff --git a/libc/src/unistd/linux/setsid.cpp b/libc/src/unistd/linux/setsid.cpp
index 9ed7307ab89829..df4629bb326cca 100644
--- a/libc/src/unistd/linux/setsid.cpp
+++ b/libc/src/unistd/linux/setsid.cpp
@@ -8,6 +8,7 @@
#include "src/unistd/setsid.h"
+#include "hdr/types/pid_t.h"
#include "src/__support/OSUtil/syscall.h" // For internal syscall function.
#include "src/__support/common.h"
#include "src/__support/macros/config.h"
diff --git a/libc/src/unistd/setsid.h b/libc/src/unistd/setsid.h
index 7f40cb84de300b..44dd7dd2ce816d 100644
--- a/libc/src/unistd/setsid.h
+++ b/libc/src/unistd/setsid.h
@@ -10,7 +10,6 @@
#define LLVM_LIBC_SRC_UNISTD_GETPID_H
#include "hdr/types/pid_t.h"
-#include "hdr/unistd_macros.h"
#include "src/__support/macros/config.h"
namespace LIBC_NAMESPACE_DECL {
More information about the libc-commits
mailing list