[libc-commits] [libc] [libc] Fix all imports of src/string/memory_utils (PR #114939)
Nick Desaulniers via libc-commits
libc-commits at lists.llvm.org
Mon Feb 3 14:00:40 PST 2025
================
@@ -54,11 +54,9 @@ add_header_library(
add_header_library(
common
HDRS
- common.h
- endian.h
macros/properties/architectures.h
macros/attributes.h
- macros/properties/cpu_features.h
----------------
nickdesaulniers wrote:
Specifically, there's a bunch of headers in src/__support/FPUtil/ and src/__support/HashTable/ that depend on cpu_features.h. If their cmake doesn't directly depend on cpu_features header library in their cmake (instead indirectly dependending on them), then this change will sever that dependency.
libc/src/__support/HashTable/CMakeLists.txt LGTM
libc/src/__support/FPUtil/CMakeLists.txt does not LGTM, so you'll need to add explicit dependencies in that cmake file on `libc.src.__support.macros.properties.cpu_features`.
https://github.com/llvm/llvm-project/pull/114939
More information about the libc-commits
mailing list