[libc-commits] [libc] [libc] Support %lc in printf (PR #169983)

Michael Jones via libc-commits libc-commits at lists.llvm.org
Thu Dec 11 10:00:16 PST 2025


================
@@ -74,3 +76,55 @@ TEST(LlvmLibcSNPrintfTest, CharsWrittenOverflow) {
   EXPECT_LT(written, 0);
   ASSERT_ERRNO_FAILURE();
 }
+
+#ifndef LIBC_COPT_PRINTF_DISABLE_WIDE
+TEST(LlvmLibcSNPrintfTest, WideCharConversion) {
----------------
michaelrj-google wrote:

this testing should go in `sprintf_test.cpp` not `snprintf_test.cpp`. I'd also prefer to have one larger `WideCharConversion` test that covers several cases instead of one for each case. That file already has a lot of tests.

https://github.com/llvm/llvm-project/pull/169983


More information about the libc-commits mailing list