[libc-commits] [libc] [libc][math][c++23] Add next{after, down, toward, up}bf16 math functions (PR #153993)
via libc-commits
libc-commits at lists.llvm.org
Tue Aug 19 13:11:43 PDT 2025
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff HEAD~1 HEAD --extensions h,cpp -- libc/src/math/generic/nextafterbf16.cpp libc/src/math/generic/nextdownbf16.cpp libc/src/math/generic/nexttowardbf16.cpp libc/src/math/generic/nextupbf16.cpp libc/src/math/nextafterbf16.h libc/src/math/nextdownbf16.h libc/src/math/nexttowardbf16.h libc/src/math/nextupbf16.h libc/test/src/math/smoke/nextafterbf16_test.cpp libc/test/src/math/smoke/nextdownbf16_test.cpp libc/test/src/math/smoke/nexttowardbf16_test.cpp libc/test/src/math/smoke/nextupbf16_test.cpp libc/test/src/math/smoke/FromfpTest.h libc/test/src/math/smoke/FromfpxTest.h libc/test/src/math/smoke/NextAfterTest.h libc/test/src/math/smoke/NextTowardTest.h libc/test/src/math/smoke/UfromfpTest.h libc/test/src/math/smoke/UfromfpxTest.h libc/test/src/math/smoke/fromfpxbf16_test.cpp libc/test/src/math/smoke/ufromfpbf16_test.cpp libc/test/src/math/smoke/ufromfpxbf16_test.cpp
``````````
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/libc/test/src/math/smoke/FromfpTest.h b/libc/test/src/math/smoke/FromfpTest.h
index d786dfdf8..708ec25ff 100644
--- a/libc/test/src/math/smoke/FromfpTest.h
+++ b/libc/test/src/math/smoke/FromfpTest.h
@@ -391,12 +391,10 @@ public:
EXPECT_FP_EQ(T(11.0), func(T(10.65), UNKNOWN_MATH_ROUNDING_DIRECTION, 5U));
EXPECT_FP_EQ(T(-11.0),
func(T(-10.65), UNKNOWN_MATH_ROUNDING_DIRECTION, 5U));
- EXPECT_FP_EQ(T(63.0),
- func(T(63.25), UNKNOWN_MATH_ROUNDING_DIRECTION, 8U));
+ EXPECT_FP_EQ(T(63.0), func(T(63.25), UNKNOWN_MATH_ROUNDING_DIRECTION, 8U));
EXPECT_FP_EQ(T(-63.0),
func(T(-63.25), UNKNOWN_MATH_ROUNDING_DIRECTION, 8U));
- EXPECT_FP_EQ(T(64.0),
- func(T(63.75), UNKNOWN_MATH_ROUNDING_DIRECTION, 8U));
+ EXPECT_FP_EQ(T(64.0), func(T(63.75), UNKNOWN_MATH_ROUNDING_DIRECTION, 8U));
EXPECT_FP_EQ(T(-64.0),
func(T(-63.75), UNKNOWN_MATH_ROUNDING_DIRECTION, 8U));
diff --git a/libc/test/src/math/smoke/FromfpxTest.h b/libc/test/src/math/smoke/FromfpxTest.h
index e837ca77e..45c2fb243 100644
--- a/libc/test/src/math/smoke/FromfpxTest.h
+++ b/libc/test/src/math/smoke/FromfpxTest.h
@@ -177,12 +177,12 @@ public:
FE_INEXACT);
EXPECT_FP_EQ_WITH_EXCEPTION(T(63.0), func(T(63.25), FP_INT_DOWNWARD, 8U),
FE_INEXACT);
- EXPECT_FP_EQ_WITH_EXCEPTION(
- T(-64.0), func(T(-63.25), FP_INT_DOWNWARD, 8U), FE_INEXACT);
+ EXPECT_FP_EQ_WITH_EXCEPTION(T(-64.0), func(T(-63.25), FP_INT_DOWNWARD, 8U),
+ FE_INEXACT);
EXPECT_FP_EQ_WITH_EXCEPTION(T(63.0), func(T(63.75), FP_INT_DOWNWARD, 8U),
FE_INEXACT);
- EXPECT_FP_EQ_WITH_EXCEPTION(
- T(-64.0), func(T(-63.75), FP_INT_DOWNWARD, 8U), FE_INEXACT);
+ EXPECT_FP_EQ_WITH_EXCEPTION(T(-64.0), func(T(-63.75), FP_INT_DOWNWARD, 8U),
+ FE_INEXACT);
}
void testFractionsDownwardOutsideRange(FromfpxFunc func) {
@@ -251,12 +251,12 @@ public:
T(-10.0), func(T(-10.65), FP_INT_TOWARDZERO, 5U), FE_INEXACT);
EXPECT_FP_EQ_WITH_EXCEPTION(T(63.0), func(T(63.25), FP_INT_TOWARDZERO, 8U),
FE_INEXACT);
- EXPECT_FP_EQ_WITH_EXCEPTION(
- T(63.0), func(T(63.25), FP_INT_TOWARDZERO, 8U), FE_INEXACT);
+ EXPECT_FP_EQ_WITH_EXCEPTION(T(63.0), func(T(63.25), FP_INT_TOWARDZERO, 8U),
+ FE_INEXACT);
EXPECT_FP_EQ_WITH_EXCEPTION(
T(-63.0), func(T(-63.25), FP_INT_TOWARDZERO, 8U), FE_INEXACT);
- EXPECT_FP_EQ_WITH_EXCEPTION(
- T(63.0), func(T(63.75), FP_INT_TOWARDZERO, 8U), FE_INEXACT);
+ EXPECT_FP_EQ_WITH_EXCEPTION(T(63.0), func(T(63.75), FP_INT_TOWARDZERO, 8U),
+ FE_INEXACT);
EXPECT_FP_EQ_WITH_EXCEPTION(
T(-63.0), func(T(-63.75), FP_INT_TOWARDZERO, 8U), FE_INEXACT);
}
@@ -397,12 +397,12 @@ public:
FE_INEXACT);
EXPECT_FP_EQ_WITH_EXCEPTION(T(63.0), func(T(63.25), FP_INT_TONEAREST, 8U),
FE_INEXACT);
- EXPECT_FP_EQ_WITH_EXCEPTION(
- T(-63.0), func(T(-63.25), FP_INT_TONEAREST, 8U), FE_INEXACT);
+ EXPECT_FP_EQ_WITH_EXCEPTION(T(-63.0), func(T(-63.25), FP_INT_TONEAREST, 8U),
+ FE_INEXACT);
EXPECT_FP_EQ_WITH_EXCEPTION(T(64.0), func(T(63.75), FP_INT_TONEAREST, 8U),
FE_INEXACT);
- EXPECT_FP_EQ_WITH_EXCEPTION(
- T(-64.0), func(T(-63.75), FP_INT_TONEAREST, 8U), FE_INEXACT);
+ EXPECT_FP_EQ_WITH_EXCEPTION(T(-64.0), func(T(-63.75), FP_INT_TONEAREST, 8U),
+ FE_INEXACT);
EXPECT_FP_EQ_WITH_EXCEPTION(T(2.0), func(T(2.3), FP_INT_TONEAREST, 3U),
FE_INEXACT);
diff --git a/libc/test/src/math/smoke/UfromfpTest.h b/libc/test/src/math/smoke/UfromfpTest.h
index 237500af8..16785dedb 100644
--- a/libc/test/src/math/smoke/UfromfpTest.h
+++ b/libc/test/src/math/smoke/UfromfpTest.h
@@ -332,10 +332,8 @@ public:
EXPECT_FP_EQ(T(2.0), func(T(1.75), UNKNOWN_MATH_ROUNDING_DIRECTION, 2U));
EXPECT_FP_EQ(T(10.0), func(T(10.32), UNKNOWN_MATH_ROUNDING_DIRECTION, 4U));
EXPECT_FP_EQ(T(11.0), func(T(10.65), UNKNOWN_MATH_ROUNDING_DIRECTION, 4U));
- EXPECT_FP_EQ(T(63.0),
- func(T(63.25), UNKNOWN_MATH_ROUNDING_DIRECTION, 7U));
- EXPECT_FP_EQ(T(64.0),
- func(T(63.75), UNKNOWN_MATH_ROUNDING_DIRECTION, 7U));
+ EXPECT_FP_EQ(T(63.0), func(T(63.25), UNKNOWN_MATH_ROUNDING_DIRECTION, 7U));
+ EXPECT_FP_EQ(T(64.0), func(T(63.75), UNKNOWN_MATH_ROUNDING_DIRECTION, 7U));
EXPECT_FP_EQ(T(2.0), func(T(2.3), UNKNOWN_MATH_ROUNDING_DIRECTION, 2U));
EXPECT_FP_EQ(T(2.0), func(T(2.5), UNKNOWN_MATH_ROUNDING_DIRECTION, 2U));
diff --git a/libc/test/src/math/smoke/UfromfpxTest.h b/libc/test/src/math/smoke/UfromfpxTest.h
index e39e09b71..1d4d3a3a1 100644
--- a/libc/test/src/math/smoke/UfromfpxTest.h
+++ b/libc/test/src/math/smoke/UfromfpxTest.h
@@ -201,10 +201,10 @@ public:
FE_INEXACT);
EXPECT_FP_EQ_WITH_EXCEPTION(T(10.0), func(T(10.65), FP_INT_TOWARDZERO, 4U),
FE_INEXACT);
- EXPECT_FP_EQ_WITH_EXCEPTION(
- T(63.0), func(T(63.25), FP_INT_TOWARDZERO, 7U), FE_INEXACT);
- EXPECT_FP_EQ_WITH_EXCEPTION(
- T(63.0), func(T(63.75), FP_INT_TOWARDZERO, 7U), FE_INEXACT);
+ EXPECT_FP_EQ_WITH_EXCEPTION(T(63.0), func(T(63.25), FP_INT_TOWARDZERO, 7U),
+ FE_INEXACT);
+ EXPECT_FP_EQ_WITH_EXCEPTION(T(63.0), func(T(63.75), FP_INT_TOWARDZERO, 7U),
+ FE_INEXACT);
}
void testFractionsTowardZeroOutsideRange(UfromfpxFunc func) {
diff --git a/libc/test/src/math/smoke/fromfpxbf16_test.cpp b/libc/test/src/math/smoke/fromfpxbf16_test.cpp
index 7630b7e88..d930ba3f4 100644
--- a/libc/test/src/math/smoke/fromfpxbf16_test.cpp
+++ b/libc/test/src/math/smoke/fromfpxbf16_test.cpp
@@ -8,7 +8,7 @@
#include "FromfpxTest.h"
-#include "src/math/fromfpxbf16.h"
#include "src/__support/FPUtil/bfloat16.h"
+#include "src/math/fromfpxbf16.h"
LIST_FROMFPX_TESTS(bfloat16, LIBC_NAMESPACE::fromfpxbf16)
diff --git a/libc/test/src/math/smoke/ufromfpbf16_test.cpp b/libc/test/src/math/smoke/ufromfpbf16_test.cpp
index 52189bbfa..2c516b030 100644
--- a/libc/test/src/math/smoke/ufromfpbf16_test.cpp
+++ b/libc/test/src/math/smoke/ufromfpbf16_test.cpp
@@ -8,7 +8,7 @@
#include "UfromfpTest.h"
-#include "src/math/ufromfpbf16.h"
#include "src/__support/FPUtil/bfloat16.h"
+#include "src/math/ufromfpbf16.h"
LIST_UFROMFP_TESTS(bfloat16, LIBC_NAMESPACE::ufromfpbf16)
diff --git a/libc/test/src/math/smoke/ufromfpxbf16_test.cpp b/libc/test/src/math/smoke/ufromfpxbf16_test.cpp
index 71d25c718..56e27276b 100644
--- a/libc/test/src/math/smoke/ufromfpxbf16_test.cpp
+++ b/libc/test/src/math/smoke/ufromfpxbf16_test.cpp
@@ -8,7 +8,7 @@
#include "UfromfpxTest.h"
-#include "src/math/ufromfpxbf16.h"
#include "src/__support/FPUtil/bfloat16.h"
+#include "src/math/ufromfpxbf16.h"
LIST_UFROMFPX_TESTS(bfloat16, LIBC_NAMESPACE::ufromfpxbf16)
``````````
</details>
https://github.com/llvm/llvm-project/pull/153993
More information about the libc-commits
mailing list