[libc-commits] [libc] [libc] Fix typo and amend restrict qualifier (PR #152410)

Caslyn Tonelli via libc-commits libc-commits at lists.llvm.org
Thu Aug 7 10:28:24 PDT 2025


================
@@ -15,8 +15,7 @@
 namespace LIBC_NAMESPACE_DECL {
 
 // TODO: https://github.com/llvm/llvm-project/issues/149911
-LLVM_LIBC_FUNCTION(int, dlinfo,
-                   (void *restrict handle, int request, void *restrict info)) {
+LLVM_LIBC_FUNCTION(int, dlinfo, (void *handle, int request, void *info)) {
----------------
Caslyn wrote:

FWIW I wasn't _sure_ about annotating dlinfo.cpp/dlinfo.h. For example, I looked at how the existing `dlsym` added `__restrict` in dlfcn.yaml[0] but omits the qualifiers in its source files[1]. 

[0] https://github.com/llvm/llvm-project/blob/main/libc/include/dlfcn.yaml#L110-L116
[1] https://github.com/llvm/llvm-project/blob/main/libc/src/dlfcn/dlsym.cpp

Double checking to proceed with adding `__restrict` on the stub definition? (I can add it on the other dlfcn  stubs as well).

https://github.com/llvm/llvm-project/pull/152410


More information about the libc-commits mailing list