[libc-commits] [libc] [libc] lfind_test.cpp: put helpers in an anonymous namespace. (PR #137821)

via libc-commits libc-commits at lists.llvm.org
Wed Apr 30 08:53:09 PDT 2025


enh-google wrote:

> Is the function supposed to becalled `compar`?

that looks weird to me, but that does seem to be used consistently throughout the test, implementation, and header.

fwiw, that's also what the original BSD implementation called it.

over in bionic's headers, i call it `__comparator` because that's probably more useful to someone in a 21st century ide, who can't even comprehend the idea of needing to keep identifier lengths down to 6 characters :-)

bruce tognazzini had a story in one of his books where someone bought a designer jacket in milan, sent it to the far east to be duplicated, and when the first shipment came back wondered why there was a weird brown mark on the cuff of every single one. they contacted the factory, and they said "that was on the original --- we'll send it back for you to see". turns out they'd copied the accidental cigarette burn too...

https://github.com/llvm/llvm-project/pull/137821


More information about the libc-commits mailing list