[libc-commits] [libc] [libc] Add support for string/memory_utils functions for AArch64 without HW FP/SIMD (PR #137592)
Guillaume Chatelet via libc-commits
libc-commits at lists.llvm.org
Mon Apr 28 01:40:31 PDT 2025
gchatelet wrote:
Regarding the memory functions (`inline_xxx`), the approach taken in this patch is to keep the same function and customize parts of it with `#ifdef`/`#endif`. For maintainability, I would prefer a different approach where we have one top function per implementation. That is, `inline_bcmp_aarch64_with_fp` / `inline_bcmp_aarch64_no_fp`. The `with_fp` implementation should be guarded by the appropriate `#ifdef`/`#endif`. Another function (e.g. `inline_bcmp_aarch64_dispatch`) should be used to create the dispatch logic. This approach allows the implementations to diverge over time and makes the logic clearer and more local.
https://github.com/llvm/llvm-project/pull/137592
More information about the libc-commits
mailing list