[libc-commits] [libc] [libc] Clean up copt naming (PR #136274)

[via libc-commits]

================
@@ -1,128 +1,128 @@
 {
   "errno": {
-    "LIBC_CONF_ERRNO_MODE": {
----------------
columbos14927 wrote:

Hi @hulxv ,
I’ve been following this issue as well, and from what I understand, there’s no need to update the names in the JSON config files. However, changes are required in the CMake files. For example, consider the following define:
`LIBC_CONF_ERRNO_MODE`
found in:

> libc/config/baremetal/config.json

If you search for this in the LLVM project, you'll see it being used here:
https://github.com/llvm/llvm-project/blob/c5d59723cbf9743f7a0534a6ca87383abb6785a7/libc/src/errno/CMakeLists.txt#L13

However, as you can see, the define
DLIBC_ERRNO_MODE
is missing the COPT in the prefix.
And it should be:

-DLIBC_COPT_ERRNO_MODE

That said, I’m not 100% sure I’m right about this—just wanted to share what I’ve observed.


https://github.com/llvm/llvm-project/pull/136274