[libc-commits] [libc] [libc] Fix incorrect unsigned comparison (PR #135595)

Michael Jones via libc-commits libc-commits at lists.llvm.org
Tue Apr 15 17:09:43 PDT 2025


https://github.com/michaelrj-google approved this pull request.

Thanks for this cleanup, this change seems correct and passes the tests + some local fuzzing.

If you're interested in creating a followup, simplifying the `if`s on 186 and 215 would be great. The intended behavior is checking if the number of digits that will be written is between 0 and `buffered_digits`/`BLOCK_SIZE * max_block_count` respectively. Making that explicit would make this change more clear.

https://github.com/llvm/llvm-project/pull/135595


More information about the libc-commits mailing list