[libc-commits] [libc] [libc][test] make `str_to_float_comparison_test` independent of C++ headers. (PR #133978)

Mikhail R. Gadelha via libc-commits libc-commits at lists.llvm.org
Tue Apr 8 14:35:46 PDT 2025


================
@@ -54,120 +69,169 @@ static inline uint64_t fastHexToU64(const char *inStr) {
   return result;
 }
 
-int checkFile(char *inputFileName, int *totalFails, int *totalBitDiffs,
-              int *detailedBitDiffs, int *total) {
-  int32_t curFails = 0;    // Only counts actual failures, not bitdiffs.
-  int32_t curBitDiffs = 0; // A bitdiff is when the expected result and actual
-                           // result are off by +/- 1 bit.
-  std::string line;
-  std::string num;
-
-  std::ifstream fileStream(inputFileName, std::ifstream::in);
+static void parseLine(char *line, ParseResult &parseResult, int32_t &curFails,
----------------
mikhailramalho wrote:

```suggestion
static void parseLine(const char *line, ParseResult &parseResult, int32_t &curFails,
```

https://github.com/llvm/llvm-project/pull/133978


More information about the libc-commits mailing list