[libc-commits] [libc] Add Linux sys call wrapper in LibC [ Issue #110122 ] (PR #110307)

[via libc-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff a285ba7529feaa7c49890e314facb5e9f4d8dc11 50bf5e92716bfca96c311da021dace6688f98fcd --extensions cpp,h -- libc/src/sys/mman/linux/remap_file_pages.cpp libc/src/sys/mman/remap_file_pages.h libc/test/src/sys/mman/linux/remap_file_pages_test.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/libc/src/sys/mman/linux/remap_file_pages.cpp b/libc/src/sys/mman/linux/remap_file_pages.cpp
index 074d24d7c9..d5fc08a00a 100644
--- a/libc/src/sys/mman/linux/remap_file_pages.cpp
+++ b/libc/src/sys/mman/linux/remap_file_pages.cpp
@@ -12,24 +12,23 @@
 #include "src/__support/common.h"
 #include "src/__support/macros/config.h"
 #include "src/errno/libc_errno.h"
-#include <sys/syscall.h>          // For syscall numbers.
+#include <sys/syscall.h> // For syscall numbers.
 
 namespace LIBC_NAMESPACE_DECL {
 
 // This function is currently linux only. It has to be refactored suitably if
 // remap_file_pages is to be supported on non-linux operating systems also.
 LLVM_LIBC_FUNCTION(int, remap_file_pages,
-                   (void *addr, size_t size, int prot, size_t pgoff, int flags))
-                    {
+                   (void *addr, size_t size, int prot, size_t pgoff,
+                    int flags)) {
 #ifdef SYS_remap_file_pages
   long syscall_number = SYS_remap_file_pages;
 #else
 #error "remap_file_pages syscall is not available."
 #endif
 
-
   int ret = LIBC_NAMESPACE::syscall_impl<int>(
-  syscall_number, reinterpret_cast<long>(addr), size, prot, pgoff, flags);
+      syscall_number, reinterpret_cast<long>(addr), size, prot, pgoff, flags);
 
   // A negative return value indicates an error with the magnitude of the
   // value being the error code.
diff --git a/libc/src/sys/mman/remap_file_pages.h b/libc/src/sys/mman/remap_file_pages.h
index cfb540fd90..77bc6b83b2 100644
--- a/libc/src/sys/mman/remap_file_pages.h
+++ b/libc/src/sys/mman/remap_file_pages.h
@@ -14,8 +14,9 @@
 
 namespace LIBC_NAMESPACE_DECL {
 
-int remap_file_pages(void *addr, size_t size, int prot, size_t pgoff, int flags);
+int remap_file_pages(void *addr, size_t size, int prot, size_t pgoff,
+                     int flags);
 
 } // namespace LIBC_NAMESPACE_DECL
 
-#endif //LLVM_LIBC_SRC_SYS_MMAN_REMAP_FILE_PAGES_H
+#endif // LLVM_LIBC_SRC_SYS_MMAN_REMAP_FILE_PAGES_H
diff --git a/libc/test/src/sys/mman/linux/remap_file_pages_test.cpp b/libc/test/src/sys/mman/linux/remap_file_pages_test.cpp
index 270ae4b670..437219e98f 100644
--- a/libc/test/src/sys/mman/linux/remap_file_pages_test.cpp
+++ b/libc/test/src/sys/mman/linux/remap_file_pages_test.cpp
@@ -10,13 +10,12 @@
 #include "src/sys/mman/mmap.h"
 #include "src/sys/mman/munmap.h"
 #include "src/sys/mman/remap_file_pages.h"
+#include "src/unistd/sysconf.h"
 #include "test/UnitTest/ErrnoSetterMatcher.h"
 #include "test/UnitTest/Test.h"
-#include "src/unistd/sysconf.h"
 
 #include <sys/mman.h>
 
-
 using LIBC_NAMESPACE::testing::ErrnoSetterMatcher::Fails;
 using LIBC_NAMESPACE::testing::ErrnoSetterMatcher::Succeeds;
 
@@ -36,7 +35,8 @@ TEST(LlvmLibcRemapFilePagesTest, NoError) {
   LIBC_NAMESPACE::libc_errno = 0;
 
   // Now try to remap the pages
-  EXPECT_THAT(LIBC_NAMESPACE::remap_file_pages(addr, page_size, PROT_READ, page_size, 0),
+  EXPECT_THAT(LIBC_NAMESPACE::remap_file_pages(addr, page_size, PROT_READ,
+                                               page_size, 0),
               Succeeds());
 
   // Reset error number for the new function
@@ -55,7 +55,8 @@ TEST(LlvmLibcRemapFilePagesTest, ErrorInvalidFlags) {
   ASSERT_NE(addr, MAP_FAILED);
 
   // Try to remap pages with an invalid flag MAP_PRIVATE
-  EXPECT_THAT(LIBC_NAMESPACE::remap_file_pages(addr, page_size, PROT_READ, 0, MAP_PRIVATE),
+  EXPECT_THAT(LIBC_NAMESPACE::remap_file_pages(addr, page_size, PROT_READ, 0,
+                                               MAP_PRIVATE),
               Fails(EINVAL));
 
   // Clean up
@@ -67,8 +68,9 @@ TEST(LlvmLibcRemapFilePagesTest, ErrorInvalidAddress) {
   ASSERT_GT(page_size, size_t(0));
 
   // Use an address that we haven't mapped
-  void *invalid_addr = reinterpret_cast<void*>(0x12345000);
+  void *invalid_addr = reinterpret_cast<void *>(0x12345000);
 
-  EXPECT_THAT(LIBC_NAMESPACE::remap_file_pages(invalid_addr, page_size, PROT_READ, 0, 0),
+  EXPECT_THAT(LIBC_NAMESPACE::remap_file_pages(invalid_addr, page_size,
+                                               PROT_READ, 0, 0),
               Fails(EINVAL));
 }
\ No newline at end of file

``````````

</details>


https://github.com/llvm/llvm-project/pull/110307