[libc-commits] [libc] [libc][AMDGPU] Disable %m in RPC server (PR #109317)

Michael Jones via libc-commits libc-commits at lists.llvm.org
Thu Sep 19 11:31:49 PDT 2024


https://github.com/michaelrj-google created https://github.com/llvm/llvm-project/pull/109317

The RPC server directly includes the printf code, but doesn't support
errno, so the %m conversion needs to be disabled there as well. This
patch does that.


>From 8c31ceee301834536139419e9932ff1d82b011f8 Mon Sep 17 00:00:00 2001
From: Michael Jones <michaelrj at google.com>
Date: Thu, 19 Sep 2024 11:30:02 -0700
Subject: [PATCH] [libc][AMDGPU] Disable %m in RPC server

The RPC server directly includes the printf code, but doesn't support
errno, so the %m conversion needs to be disabled there as well. This
patch does that.
---
 libc/utils/gpu/server/CMakeLists.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/libc/utils/gpu/server/CMakeLists.txt b/libc/utils/gpu/server/CMakeLists.txt
index 13509dc3da3612..50056fb376b699 100644
--- a/libc/utils/gpu/server/CMakeLists.txt
+++ b/libc/utils/gpu/server/CMakeLists.txt
@@ -19,6 +19,7 @@ target_compile_definitions(llvmlibc_rpc_server PUBLIC
                            LIBC_COPT_ARRAY_ARG_LIST
                            LIBC_COPT_PRINTF_DISABLE_WRITE_INT
                            LIBC_COPT_PRINTF_DISABLE_INDEX_MODE
+                           LIBC_COPT_PRINTF_DISABLE_STRERROR
                            LIBC_NAMESPACE=${LIBC_NAMESPACE})
 
 # Install the server and associated header.



More information about the libc-commits mailing list