[libc-commits] [libc] [libc] Correct the entrypoints list for ARM/darwin (PR #107331)
via libc-commits
libc-commits at lists.llvm.org
Wed Sep 4 16:55:56 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-libc
Author: Michael Jones (michaelrj-google)
<details>
<summary>Changes</summary>
These entrypoints were added to every target without testing. They don't
work on ARM macs.
---
Full diff: https://github.com/llvm/llvm-project/pull/107331.diff
1 Files Affected:
- (modified) libc/config/darwin/arm/entrypoints.txt (-12)
``````````diff
diff --git a/libc/config/darwin/arm/entrypoints.txt b/libc/config/darwin/arm/entrypoints.txt
index 36da9e13136638..a012504daa5c54 100644
--- a/libc/config/darwin/arm/entrypoints.txt
+++ b/libc/config/darwin/arm/entrypoints.txt
@@ -94,16 +94,6 @@ set(TARGET_LIBC_ENTRYPOINTS
libc.src.stdlib.calloc
libc.src.stdlib.realloc
libc.src.stdlib.free
-
- # stdio.h external entrypoints
- libc.src.stdio.snprintf
- libc.src.stdio.sprintf
- libc.src.stdio.asprintf
- libc.src.stdio.asprintf
- libc.src.stdio.vprintf
- libc.src.stdio.vsnprintf
- libc.src.stdio.vsprintf
- libc.src.stdio.vasprintf
)
set(TARGET_LIBM_ENTRYPOINTS
@@ -148,9 +138,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.cospif
libc.src.math.dfmal
libc.src.math.dsqrtl
- libc.src.math.daddl
libc.src.math.ddivl
- libc.src.math.dsubl
libc.src.math.erff
libc.src.math.exp
libc.src.math.expf
``````````
</details>
https://github.com/llvm/llvm-project/pull/107331
More information about the libc-commits
mailing list