[libc-commits] [libc] [libc] fix behavior of strrchr(x, '\0') (PR #112620)
Nick Desaulniers via libc-commits
libc-commits at lists.llvm.org
Wed Oct 30 15:55:15 PDT 2024
================
@@ -162,6 +162,14 @@ class Test {
(unsigned long long)RHS, LHSStr, RHSStr, Loc);
}
+ // Helper to allow macro invocations like `ASSERT_EQ(foo, nullptr)`.
+ template <typename ValType,
+ cpp::enable_if_t<cpp::is_pointer_v<ValType>, ValType> = nullptr>
+ bool test(TestCond Cond, ValType LHS, std::nullptr_t, const char *LHSStr,
----------------
nickdesaulniers wrote:
Looks like this is breaking the buildbots.
```
/home/libc_worker/libc-riscv64-debian/libc-riscv64-debian-fullbuild-dbg/llvm-project/libc/test/UnitTest/LibcTest.h:168:41: error: use of undeclared identifier 'std'
bool test(TestCond Cond, ValType LHS, std::nullptr_t, const char *LHSStr,
^
```
mind reverting if you can't fix forward quickly?
https://github.com/llvm/llvm-project/pull/112620
More information about the libc-commits
mailing list