[libc-commits] [libc] [libc] fix behavior of strrchr(x, '\0') (PR #112620)

LLVM Continuous Integration via libc-commits libc-commits at lists.llvm.org
Wed Oct 30 15:09:57 PDT 2024 

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `libc-aarch64-ubuntu-fullbuild-dbg` running on `libc-aarch64-ubuntu` while building `libc` at step 4 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/71/builds/9495

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 4 (annotate) failure: 'python ../llvm-zorg/zorg/buildbot/builders/annotated/libc-linux.py ...' (failure)
...
[24/26] Building CXX object projects/libc/src/string/CMakeFiles/libc.src.string.strncat.dir/strncat.cpp.o
[25/26] Building CXX object projects/libc/src/string/CMakeFiles/libc.src.string.strrchr.dir/strrchr.cpp.o
[26/26] Linking CXX static library projects/libc/lib/libc.a
@@@BUILD_STEP build libc-startup@@@
Running: ninja libc-startup
ninja: no work to do.
@@@BUILD_STEP libc-unit-tests@@@
Running: ninja libc-unit-tests
[1/2412] Running unit test libc.test.include.issubnormal_c_test.__unit__
[2/2412] Building CXX object projects/libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.truncf16_test.__unit__.__NO_ROUND_OPT.__build__.dir/truncf16_test.cpp.o
FAILED: projects/libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.truncf16_test.__unit__.__NO_ROUND_OPT.__build__.dir/truncf16_test.cpp.o 
/usr/bin/clang++ -DLIBC_NAMESPACE=__llvm_libc_19_0_0_git -D_DEBUG -Iprojects/libc/test/src/math/smoke -I/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/src/math/smoke -I/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc -isystem projects/libc/include -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -g -fpie -DLIBC_FULL_BUILD -ffreestanding -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-rtti -Wno-c99-extensions -Wno-gnu-imaginary-constant -Wno-pedantic -std=c++17 -MD -MT projects/libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.truncf16_test.__unit__.__NO_ROUND_OPT.__build__.dir/truncf16_test.cpp.o -MF projects/libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.truncf16_test.__unit__.__NO_ROUND_OPT.__build__.dir/truncf16_test.cpp.o.d -o projects/libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.truncf16_test.__unit__.__NO_ROUND_OPT.__build__.dir/truncf16_test.cpp.o -c /home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/src/math/smoke/truncf16_test.cpp
In file included from /home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/src/math/smoke/truncf16_test.cpp:9:
In file included from /home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/src/math/smoke/TruncTest.h:12:
In file included from /home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/UnitTest/FEnvSafeTest.h:15:
In file included from /home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/UnitTest/Test.h:37:
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/UnitTest/LibcTest.h:168:41: error: use of undeclared identifier 'std'
  bool test(TestCond Cond, ValType LHS, std::nullptr_t, const char *LHSStr,
                                        ^
1 error generated.
[3/2412] Building CXX object projects/libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.canonicalizel_test.__unit__.__build__.dir/canonicalizel_test.cpp.o
FAILED: projects/libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.canonicalizel_test.__unit__.__build__.dir/canonicalizel_test.cpp.o 
/usr/bin/clang++ -DLIBC_NAMESPACE=__llvm_libc_19_0_0_git -D_DEBUG -Iprojects/libc/test/src/math/smoke -I/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/src/math/smoke -I/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc -isystem projects/libc/include -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -g -fpie -DLIBC_FULL_BUILD -ffreestanding -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-rtti -Wno-c99-extensions -Wno-gnu-imaginary-constant -Wno-pedantic -std=c++17 -MD -MT projects/libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.canonicalizel_test.__unit__.__build__.dir/canonicalizel_test.cpp.o -MF projects/libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.canonicalizel_test.__unit__.__build__.dir/canonicalizel_test.cpp.o.d -o projects/libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.canonicalizel_test.__unit__.__build__.dir/canonicalizel_test.cpp.o -c /home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/src/math/smoke/canonicalizel_test.cpp
In file included from /home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/src/math/smoke/canonicalizel_test.cpp:9:
In file included from /home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/src/math/smoke/CanonicalizeTest.h:15:
In file included from /home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/UnitTest/FEnvSafeTest.h:15:
In file included from /home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/UnitTest/Test.h:37:
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/UnitTest/LibcTest.h:168:41: error: use of undeclared identifier 'std'
  bool test(TestCond Cond, ValType LHS, std::nullptr_t, const char *LHSStr,
                                        ^
1 error generated.
[4/2412] Building CXX object projects/libc/test/src/string/memory_utils/CMakeFiles/libc.test.src.string.memory_utils.utils_test.__unit__.__build__.dir/utils_test.cpp.o
FAILED: projects/libc/test/src/string/memory_utils/CMakeFiles/libc.test.src.string.memory_utils.utils_test.__unit__.__build__.dir/utils_test.cpp.o 
/usr/bin/clang++ -DLIBC_NAMESPACE=__llvm_libc_19_0_0_git -D_DEBUG -Iprojects/libc/test/src/string/memory_utils -I/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/src/string/memory_utils -I/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc -isystem projects/libc/include -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -g -fpie -DLIBC_FULL_BUILD -ffreestanding -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-rtti -Wno-c99-extensions -Wno-gnu-imaginary-constant -Wno-pedantic -mcpu=native -std=c++17 -MD -MT projects/libc/test/src/string/memory_utils/CMakeFiles/libc.test.src.string.memory_utils.utils_test.__unit__.__build__.dir/utils_test.cpp.o -MF projects/libc/test/src/string/memory_utils/CMakeFiles/libc.test.src.string.memory_utils.utils_test.__unit__.__build__.dir/utils_test.cpp.o.d -o projects/libc/test/src/string/memory_utils/CMakeFiles/libc.test.src.string.memory_utils.utils_test.__unit__.__build__.dir/utils_test.cpp.o -c /home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/src/string/memory_utils/utils_test.cpp
In file included from /home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/src/string/memory_utils/utils_test.cpp:12:
In file included from /home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/UnitTest/Test.h:37:
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/UnitTest/LibcTest.h:168:41: error: use of undeclared identifier 'std'
  bool test(TestCond Cond, ValType LHS, std::nullptr_t, const char *LHSStr,
                                        ^
1 error generated.
[5/2412] Building CXX object projects/libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.fsqrt_test.__unit__.__build__.dir/fsqrt_test.cpp.o
FAILED: projects/libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.fsqrt_test.__unit__.__build__.dir/fsqrt_test.cpp.o 
/usr/bin/clang++ -DLIBC_NAMESPACE=__llvm_libc_19_0_0_git -D_DEBUG -Iprojects/libc/test/src/math/smoke -I/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/src/math/smoke -I/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc -isystem projects/libc/include -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -g -fpie -DLIBC_FULL_BUILD -ffreestanding -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-rtti -Wno-c99-extensions -Wno-gnu-imaginary-constant -Wno-pedantic -std=c++17 -MD -MT projects/libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.fsqrt_test.__unit__.__build__.dir/fsqrt_test.cpp.o -MF projects/libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.fsqrt_test.__unit__.__build__.dir/fsqrt_test.cpp.o.d -o projects/libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.fsqrt_test.__unit__.__build__.dir/fsqrt_test.cpp.o -c /home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/src/math/smoke/fsqrt_test.cpp
In file included from /home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/src/math/smoke/fsqrt_test.cpp:9:
In file included from /home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/src/math/smoke/SqrtTest.h:9:
In file included from /home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/UnitTest/FEnvSafeTest.h:15:
In file included from /home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/UnitTest/Test.h:37:
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/UnitTest/LibcTest.h:168:41: error: use of undeclared identifier 'std'
  bool test(TestCond Cond, ValType LHS, std::nullptr_t, const char *LHSStr,

```

</details>

https://github.com/llvm/llvm-project/pull/112620

More information about the libc-commits mailing list