[libc-commits] [libc] [libc] fix behavior of strrchr(x, '\0') (PR #112620)

Nick Desaulniers via libc-commits libc-commits at lists.llvm.org
Wed Oct 16 14:39:58 PDT 2024


================
@@ -114,25 +117,25 @@ template <auto Func> struct StrrchrTest : public LIBC_NAMESPACE::testing::Test {
     const char *src = "abcde";
 
     // Should return null terminator.
-    ASSERT_STREQ(Func(src, '\0'), "");
+    ASSERT_TRUE(Func(src, '\0') != nullptr);
----------------
nickdesaulniers wrote:

I think this hunk specifically no longer aligns with the commend above it?

---

We do define a (currently unused) `ASSERT_STRNE`.

https://github.com/llvm/llvm-project/pull/112620


More information about the libc-commits mailing list