[libc-commits] [libc] [libc] Remove dependency on `cpp::function` in `rpc.h` (PR #112422)

Tue Oct 15 12:43:21 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `openmp-offload-libc-amdgpu-runtime` running on `omp-vega20-1` while building `libc` at step 11 "Add check check-libc-amdgcn-amd-amdhsa".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/73/builds/7102

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 11 (Add check check-libc-amdgcn-amd-amdhsa) failure: test (failure)
...
[1522/2641] Linking CXX static library libc/test/integration/src/__support/GPU/liblibc.test.integration.src.__support.GPU.scan_reduce_test.libc.a
[1523/2641] Linking CXX static library libc/test/integration/src/stdio/liblibc.test.integration.src.stdio.sprintf_size_test_no_sprintf.libc.a
[1524/2641] Building CXX object libc/test/integration/startup/gpu/CMakeFiles/libc.test.integration.startup.gpu.init_fini_array_test.__build__.dir/init_fini_array_test.cpp.o
[1525/2641] Linking CXX static library libc/test/integration/src/stdio/liblibc.test.integration.src.stdio.sprintf_size_test.libc.a
[1526/2641] Building CXX object libc/test/src/string/CMakeFiles/libc.test.src.string.strpbrk_test.__hermetic__.__build__.dir/strpbrk_test.cpp.o
[1527/2641] Building CXX object libc/test/src/string/CMakeFiles/libc.test.src.string.strncpy_test.__hermetic__.__build__.dir/strncpy_test.cpp.o
[1528/2641] Linking CXX static library libc/test/integration/src/stdio/gpu/liblibc.test.integration.src.stdio.gpu.printf_test.libc.a
[1529/2641] Building CXX object libc/test/src/string/CMakeFiles/libc.test.src.string.strrchr_test.__hermetic__.__build__.dir/strrchr_test.cpp.o
[1530/2641] Linking CXX static library libc/test/integration/src/stdlib/liblibc.test.integration.src.stdlib.getenv_test.libc.a
[1531/2641] Building CXX object libc/test/integration/startup/gpu/CMakeFiles/libc.test.integration.startup.gpu.startup_rpc_test.__build__.dir/rpc_test.cpp.o
FAILED: libc/test/integration/startup/gpu/CMakeFiles/libc.test.integration.startup.gpu.startup_rpc_test.__build__.dir/rpc_test.cpp.o 
/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/./bin/clang++ --target=amdgcn-amd-amdhsa -DLIBC_NAMESPACE=__llvm_libc_20_0_0_git -D__LIBC_USE_FLOAT16_CONVERSION -I/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/libc -isystem /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/include/amdgcn-amd-amdhsa -O3 -DNDEBUG -UNDEBUG --target=amdgcn-amd-amdhsa -fpie -DLIBC_FULL_BUILD -ffreestanding -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-rtti -ffixed-point -Wno-c99-extensions -Wno-gnu-imaginary-constant -Wno-pedantic -Wno-multi-gpu -nogpulib -mcpu=gfx906 -flto -mcode-object-version=5 -MD -MT libc/test/integration/startup/gpu/CMakeFiles/libc.test.integration.startup.gpu.startup_rpc_test.__build__.dir/rpc_test.cpp.o -MF libc/test/integration/startup/gpu/CMakeFiles/libc.test.integration.startup.gpu.startup_rpc_test.__build__.dir/rpc_test.cpp.o.d -o libc/test/integration/startup/gpu/CMakeFiles/libc.test.integration.startup.gpu.startup_rpc_test.__build__.dir/rpc_test.cpp.o -c /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/libc/test/integration/startup/gpu/rpc_test.cpp
In file included from /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/libc/test/integration/startup/gpu/rpc_test.cpp:11:
In file included from /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/libc/src/__support/RPC/rpc_client.h:12:
/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/libc/src/__support/RPC/rpc.h:272:5: error: no matching function for call to object of type '(lambda at /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/libc/test/integration/startup/gpu/rpc_test.cpp:23:9)'
  272 |     fn(&slot[gpu::get_lane_id()], gpu::get_lane_id());
      |     ^~
/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/libc/src/__support/RPC/rpc.h:390:3: note: in instantiation of function template specialization '__llvm_libc_20_0_0_git::rpc::invoke_rpc<(lambda at /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/libc/test/integration/startup/gpu/rpc_test.cpp:23:9) &>' requested here
  390 |   invoke_rpc(fill, lane_size, process.header[index].mask,
      |   ^
/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/libc/src/__support/RPC/rpc.h:422:3: note: in instantiation of function template specialization '__llvm_libc_20_0_0_git::rpc::Port<false>::send<(lambda at /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/libc/test/integration/startup/gpu/rpc_test.cpp:23:9)>' requested here
  422 |   send(fill);
      |   ^
/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/libc/test/integration/startup/gpu/rpc_test.cpp:22:10: note: in instantiation of function template specialization '__llvm_libc_20_0_0_git::rpc::Port<false>::send_and_recv<(lambda at /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/libc/test/integration/startup/gpu/rpc_test.cpp:23:9), (lambda at /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/libc/test/integration/startup/gpu/rpc_test.cpp:26:9)>' requested here
   22 |     port.send_and_recv(
      |          ^
/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/libc/test/integration/startup/gpu/rpc_test.cpp:23:9: note: candidate function not viable: requires single argument 'buffer', but 2 arguments were provided
   23 |         [=](rpc::Buffer *buffer) {
      |         ^   ~~~~~~~~~~~~~~~~~~~
In file included from /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/libc/test/integration/startup/gpu/rpc_test.cpp:11:
In file included from /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/libc/src/__support/RPC/rpc_client.h:12:
/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/libc/src/__support/RPC/rpc.h:272:5: error: no matching function for call to object of type '(lambda at /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/libc/test/integration/startup/gpu/rpc_test.cpp:26:9)'
  272 |     fn(&slot[gpu::get_lane_id()], gpu::get_lane_id());
      |     ^~
/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/libc/src/__support/RPC/rpc.h:412:3: note: in instantiation of function template specialization '__llvm_libc_20_0_0_git::rpc::invoke_rpc<(lambda at /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/libc/test/integration/startup/gpu/rpc_test.cpp:26:9) &>' requested here
  412 |   invoke_rpc(use, lane_size, process.header[index].mask,
      |   ^
/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/libc/src/__support/RPC/rpc.h:423:3: note: in instantiation of function template specialization '__llvm_libc_20_0_0_git::rpc::Port<false>::recv<(lambda at /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/libc/test/integration/startup/gpu/rpc_test.cpp:26:9)>' requested here
  423 |   recv(use);
      |   ^
/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/libc/test/integration/startup/gpu/rpc_test.cpp:22:10: note: in instantiation of function template specialization '__llvm_libc_20_0_0_git::rpc::Port<false>::send_and_recv<(lambda at /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/libc/test/integration/startup/gpu/rpc_test.cpp:23:9), (lambda at /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/libc/test/integration/startup/gpu/rpc_test.cpp:26:9)>' requested here
   22 |     port.send_and_recv(
      |          ^
/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/libc/test/integration/startup/gpu/rpc_test.cpp:26:9: note: candidate function not viable: requires single argument 'buffer', but 2 arguments were provided
   26 |         [&](rpc::Buffer *buffer) {
      |         ^   ~~~~~~~~~~~~~~~~~~~
In file included from /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/libc/test/integration/startup/gpu/rpc_test.cpp:11:
In file included from /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/libc/src/__support/RPC/rpc_client.h:12:
/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/libc/src/__support/RPC/rpc.h:272:5: error: no matching function for call to object of type '(lambda at /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/libc/test/integration/startup/gpu/rpc_test.cpp:37:13)'

```

</details>

https://github.com/llvm/llvm-project/pull/112422