[libc-commits] [libc] [libc][math] Improve performance of double precision trig functions. (PR #111793)

Nick Desaulniers via libc-commits libc-commits at lists.llvm.org
Thu Oct 10 08:52:09 PDT 2024


================
@@ -73,6 +73,26 @@ template <size_t N = 27> LIBC_INLINE constexpr DoubleDouble split(double a) {
   return r;
 }
 
+// Helper for non-fma exact mult where the first number is already splitted.
+template <bool NO_FMA_ALL_ROUNDINGS = false>
----------------
nickdesaulniers wrote:

Having the double negation here adds slight cognitive burden to reading this. Consider making this:

```suggestion
template <bool FMA_ALL_ROUNDINGS = true>
```
Then flipping the condition below.

https://github.com/llvm/llvm-project/pull/111793


More information about the libc-commits mailing list