[libc-commits] [libc] [libc] Template the writing mode for the writer class (PR #111559)

Joseph Huber via libc-commits libc-commits at lists.llvm.org
Tue Oct 8 10:32:05 PDT 2024


jhuber6 wrote:

> patch LGTM, but I'll defer to @michaelrj-google to check that the correct modes are used explicitly in each case.
> 
> I'm guessing this PR comes with a tradeoff to code size?

Yes, since we put everything in the headers it'll now be copied between the unique users. however, most of these already go through a common case (i.e. vfprintf_internal) so I'm not too concerned. This makes it actually usable from a GPU context however, and allows for more optimizations.

https://github.com/llvm/llvm-project/pull/111559


More information about the libc-commits mailing list