[libc-commits] [libc] [libc] Template the writing mode for the writer class (PR #111559)

Nick Desaulniers via libc-commits libc-commits at lists.llvm.org
Tue Oct 8 10:20:39 PDT 2024


================
@@ -167,8 +167,9 @@ static void handle_printf(rpc::Server::Port &port, TempStorage &temp_storage) {
       continue;
 
     char *buffer = temp_storage.alloc(buffer_size[lane]);
-    WriteBuffer wb(buffer, buffer_size[lane]);
-    Writer writer(&wb);
+    WriteBuffer<WriteMode::FILL_BUFF_AND_DROP_OVERFLOW> wb(buffer,
----------------
nickdesaulniers wrote:

If this enum is the most common, should we make it the default? Or is it better to be explicit every time?

https://github.com/llvm/llvm-project/pull/111559


More information about the libc-commits mailing list