[libc-commits] [libc] [libc] Add sinpif16 function (PR #110994)

via libc-commits libc-commits at lists.llvm.org
Mon Oct 7 02:05:56 PDT 2024


================
@@ -528,6 +528,22 @@ add_entrypoint_object(
     -O3
 )
 
+add_entrypoint_object(
+  sinpif16
+  SRCS
+    sinpif16.cpp
+  HDRS
+    ../sinpif16.h
+  DEPENDS
+    libc.src.__support.macros.properties.types
+    libc.src.__support.FPUtil.fp_bits
+    libc.src.__support.FPUtil.multiply_add
+    libc.src.__support.common
+    libc.src.__support.macros.config
----------------
overmighty wrote:

Some dependencies are missing. `libc.src.__support.macros.config` is already added by https://github.com/llvm/llvm-project/blob/5cfc6bc22b6284a2e0b78c71c84d272fcc8ac850/libc/cmake/modules/LLVMLibCObjectRules.cmake#L77

```suggestion
  DEPENDS
    libc.src.__support.common
    libc.src.__support.FPUtil.fenv_impl
    libc.src.__support.FPUtil.fp_bits
    libc.src.__support.FPUtil.multiply_add
    libc.src.__support.FPUtil.nearest_integer
    libc.src.__support.FPUtil.poly_eval
    libc.src.__support.properties.types
```

https://github.com/llvm/llvm-project/pull/110994


More information about the libc-commits mailing list