[libc-commits] [libc] [libc][math] Implement `iscanonical[f|l]` as a libc math function (PR #110565)
LLVM Continuous Integration via libc-commits
libc-commits at lists.llvm.org
Wed Oct 2 07:16:29 PDT 2024
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `libc-aarch64-ubuntu-dbg` running on `libc-aarch64-ubuntu` while building `libc` at step 4 "annotate".
Full details are available at: https://lab.llvm.org/buildbot/#/builders/104/builds/7764
<details>
<summary>Here is the relevant piece of the build log for the reference</summary>
```
Step 4 (annotate) failure: 'python ../llvm-zorg/zorg/buildbot/builders/annotated/libc-linux.py ...' (failure)
...
[ OK ] LlvmLibcTruncTest.Range (31 ms)
Ran 4 tests. PASS: 4 FAIL: 0
[23/1014] Running unit test libc.test.src.math.fabs_test.__unit__
[==========] Running 2 tests from 1 test suite.
[ RUN ] LlvmLibcFAbsTest.SpecialNumbers
[ OK ] LlvmLibcFAbsTest.SpecialNumbers (2 us)
[ RUN ] LlvmLibcFAbsTest.Range
[ OK ] LlvmLibcFAbsTest.Range (33 ms)
Ran 2 tests. PASS: 2 FAIL: 0
[24/1014] Building CXX object projects/libc/src/math/generic/CMakeFiles/libc.src.math.generic.iscanonical.__internal__.dir/iscanonical.cpp.o
FAILED: projects/libc/src/math/generic/CMakeFiles/libc.src.math.generic.iscanonical.__internal__.dir/iscanonical.cpp.o
/usr/bin/clang++ -DLIBC_NAMESPACE=__llvm_libc_18_0_0_git -D_DEBUG -Iprojects/libc/src/math/generic -I/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu/llvm-project/libc/src/math/generic -I/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu/llvm-project/libc -isystem projects/libc/include -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -g -DLIBC_QSORT_IMPL=LIBC_QSORT_QUICK_SORT -DLIBC_ADD_NULL_CHECKS -fpie -fno-builtin -fno-exceptions -fno-lax-vector-conversions -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-rtti -ftrivial-auto-var-init=pattern -fno-omit-frame-pointer -Wall -Wextra -Werror -Wconversion -Wno-sign-conversion -Wimplicit-fallthrough -Wwrite-strings -Wextra-semi -Wnewline-eof -Wnonportable-system-include-path -Wstrict-prototypes -Wthread-safety -Wglobal-constructors -O3 -std=c++17 -MD -MT projects/libc/src/math/generic/CMakeFiles/libc.src.math.generic.iscanonical.__internal__.dir/iscanonical.cpp.o -MF projects/libc/src/math/generic/CMakeFiles/libc.src.math.generic.iscanonical.__internal__.dir/iscanonical.cpp.o.d -o projects/libc/src/math/generic/CMakeFiles/libc.src.math.generic.iscanonical.__internal__.dir/iscanonical.cpp.o -c /home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu/llvm-project/libc/src/math/generic/iscanonical.cpp
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu/llvm-project/libc/src/math/generic/iscanonical.cpp:16:25: error: expected unqualified-id
LLVM_LIBC_FUNCTION(int, iscanonical, (double x)) {
^
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu/llvm-project/libc/src/math/generic/iscanonical.cpp:16:25: error: expected ')'
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu/llvm-project/libc/src/math/generic/iscanonical.cpp:16:25: note: to match this '('
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu/llvm-project/libc/src/math/generic/iscanonical.cpp:16:46: error: expected ')'
LLVM_LIBC_FUNCTION(int, iscanonical, (double x)) {
^
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu/llvm-project/libc/src/math/generic/iscanonical.cpp:16:25: note: to match this '('
LLVM_LIBC_FUNCTION(int, iscanonical, (double x)) {
^
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu/llvm-project/libc/src/math/generic/iscanonical.cpp:16:25: error: expected ')'
LLVM_LIBC_FUNCTION(int, iscanonical, (double x)) {
^
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu/llvm-project/libc/src/math/generic/iscanonical.cpp:16:25: note: to match this '('
4 errors generated.
[25/1014] Running unit test libc.test.src.math.modf_test.__unit__
[==========] Running 4 tests from 1 test suite.
[ RUN ] LlvmLibcModfTest.SpecialNumbers
[ OK ] LlvmLibcModfTest.SpecialNumbers (3 us)
[ RUN ] LlvmLibcModfTest.RoundedNubmers
[ OK ] LlvmLibcModfTest.RoundedNubmers (3 us)
[ RUN ] LlvmLibcModfTest.Fractions
[ OK ] LlvmLibcModfTest.Fractions (3 us)
[ RUN ] LlvmLibcModfTest.Range
[ OK ] LlvmLibcModfTest.Range (41 ms)
Ran 4 tests. PASS: 4 FAIL: 0
[26/1014] Running unit test libc.test.src.math.llrintf16_test.__unit__
[==========] Running 6 tests from 1 test suite.
[ RUN ] LlvmLibcRoundToIntegerTest.InfinityAndNaN
[ OK ] LlvmLibcRoundToIntegerTest.InfinityAndNaN (4 us)
[ RUN ] LlvmLibcRoundToIntegerTest.RoundNumbers
[ OK ] LlvmLibcRoundToIntegerTest.RoundNumbers (3 us)
[ RUN ] LlvmLibcRoundToIntegerTest.Fractions
[ OK ] LlvmLibcRoundToIntegerTest.Fractions (70 us)
[ RUN ] LlvmLibcRoundToIntegerTest.IntegerOverflow
[ OK ] LlvmLibcRoundToIntegerTest.IntegerOverflow (0 ns)
Step 7 (libc-unit-tests) failure: libc-unit-tests (failure)
...
[ OK ] LlvmLibcTruncTest.Range (31 ms)
Ran 4 tests. PASS: 4 FAIL: 0
[23/1014] Running unit test libc.test.src.math.fabs_test.__unit__
[==========] Running 2 tests from 1 test suite.
[ RUN ] LlvmLibcFAbsTest.SpecialNumbers
[ OK ] LlvmLibcFAbsTest.SpecialNumbers (2 us)
[ RUN ] LlvmLibcFAbsTest.Range
[ OK ] LlvmLibcFAbsTest.Range (33 ms)
Ran 2 tests. PASS: 2 FAIL: 0
[24/1014] Building CXX object projects/libc/src/math/generic/CMakeFiles/libc.src.math.generic.iscanonical.__internal__.dir/iscanonical.cpp.o
FAILED: projects/libc/src/math/generic/CMakeFiles/libc.src.math.generic.iscanonical.__internal__.dir/iscanonical.cpp.o
/usr/bin/clang++ -DLIBC_NAMESPACE=__llvm_libc_18_0_0_git -D_DEBUG -Iprojects/libc/src/math/generic -I/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu/llvm-project/libc/src/math/generic -I/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu/llvm-project/libc -isystem projects/libc/include -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -g -DLIBC_QSORT_IMPL=LIBC_QSORT_QUICK_SORT -DLIBC_ADD_NULL_CHECKS -fpie -fno-builtin -fno-exceptions -fno-lax-vector-conversions -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-rtti -ftrivial-auto-var-init=pattern -fno-omit-frame-pointer -Wall -Wextra -Werror -Wconversion -Wno-sign-conversion -Wimplicit-fallthrough -Wwrite-strings -Wextra-semi -Wnewline-eof -Wnonportable-system-include-path -Wstrict-prototypes -Wthread-safety -Wglobal-constructors -O3 -std=c++17 -MD -MT projects/libc/src/math/generic/CMakeFiles/libc.src.math.generic.iscanonical.__internal__.dir/iscanonical.cpp.o -MF projects/libc/src/math/generic/CMakeFiles/libc.src.math.generic.iscanonical.__internal__.dir/iscanonical.cpp.o.d -o projects/libc/src/math/generic/CMakeFiles/libc.src.math.generic.iscanonical.__internal__.dir/iscanonical.cpp.o -c /home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu/llvm-project/libc/src/math/generic/iscanonical.cpp
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu/llvm-project/libc/src/math/generic/iscanonical.cpp:16:25: error: expected unqualified-id
LLVM_LIBC_FUNCTION(int, iscanonical, (double x)) {
^
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu/llvm-project/libc/src/math/generic/iscanonical.cpp:16:25: error: expected ')'
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu/llvm-project/libc/src/math/generic/iscanonical.cpp:16:25: note: to match this '('
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu/llvm-project/libc/src/math/generic/iscanonical.cpp:16:46: error: expected ')'
LLVM_LIBC_FUNCTION(int, iscanonical, (double x)) {
^
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu/llvm-project/libc/src/math/generic/iscanonical.cpp:16:25: note: to match this '('
LLVM_LIBC_FUNCTION(int, iscanonical, (double x)) {
^
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu/llvm-project/libc/src/math/generic/iscanonical.cpp:16:25: error: expected ')'
LLVM_LIBC_FUNCTION(int, iscanonical, (double x)) {
^
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu/llvm-project/libc/src/math/generic/iscanonical.cpp:16:25: note: to match this '('
4 errors generated.
[25/1014] Running unit test libc.test.src.math.modf_test.__unit__
[==========] Running 4 tests from 1 test suite.
[ RUN ] LlvmLibcModfTest.SpecialNumbers
[ OK ] LlvmLibcModfTest.SpecialNumbers (3 us)
[ RUN ] LlvmLibcModfTest.RoundedNubmers
[ OK ] LlvmLibcModfTest.RoundedNubmers (3 us)
[ RUN ] LlvmLibcModfTest.Fractions
[ OK ] LlvmLibcModfTest.Fractions (3 us)
[ RUN ] LlvmLibcModfTest.Range
[ OK ] LlvmLibcModfTest.Range (41 ms)
Ran 4 tests. PASS: 4 FAIL: 0
[26/1014] Running unit test libc.test.src.math.llrintf16_test.__unit__
[==========] Running 6 tests from 1 test suite.
[ RUN ] LlvmLibcRoundToIntegerTest.InfinityAndNaN
[ OK ] LlvmLibcRoundToIntegerTest.InfinityAndNaN (4 us)
[ RUN ] LlvmLibcRoundToIntegerTest.RoundNumbers
[ OK ] LlvmLibcRoundToIntegerTest.RoundNumbers (3 us)
[ RUN ] LlvmLibcRoundToIntegerTest.Fractions
[ OK ] LlvmLibcRoundToIntegerTest.Fractions (70 us)
[ RUN ] LlvmLibcRoundToIntegerTest.IntegerOverflow
[ OK ] LlvmLibcRoundToIntegerTest.IntegerOverflow (0 ns)
```
</details>
https://github.com/llvm/llvm-project/pull/110565
More information about the libc-commits
mailing list