[libc-commits] [libc] [libc] Add `ctime_s` (PR #110676)

Зишан Мирза via libc-commits libc-commits at lists.llvm.org
Tue Oct 1 10:17:04 PDT 2024


https://github.com/zimirza requested changes to this pull request.

This is great. Thank you for the pull request. Could you also add the following:

- We also need to add `ctime_s` to the cmake file so it will get included in the build, `libc/src/time/CMakeLists.txt`.
- We should also add `ctime_s` to the different architectures in `libc/config/<...>/<...>/entrypoints.txt`.
- newhdrgen: `libc/newhdrgen/yaml/time.yaml`
- spec file: `libc/spec/stdc.td`
- Could you also add some tests? These are in `libc/test/src/time/`. Make sure to include the tests in the cmake file, `libc/test/src/time/CMakeLists.txt`. You can run tests for this with `ninja` or `make`, `ninja libc.test.src.time.ctime_s_test`.

https://github.com/llvm/llvm-project/pull/110676


More information about the libc-commits mailing list