[libc-commits] [libc] [llvm] [libc] Move libc server handlers to a shared header (PR #117908)
Shilei Tian via libc-commits
libc-commits at lists.llvm.org
Wed Nov 27 12:32:07 PST 2024
================
@@ -32,10 +32,7 @@ elseif(${LIBOMPTARGET_GPU_LIBC_SUPPORT})
target_link_libraries(PluginCommon PRIVATE ${llvmlibc_rpc_server})
target_compile_definitions(PluginCommon PRIVATE LIBOMPTARGET_RPC_SUPPORT)
# We may need to get the headers directly from the 'libc' source directory.
- target_include_directories(PluginCommon PRIVATE
- ${CMAKE_SOURCE_DIR}/../libc/utils/gpu/server
- ${CMAKE_SOURCE_DIR}/../libc/
- ${CMAKE_SOURCE_DIR}/../libc/include)
+ target_include_directories(PluginCommon PRIVATE ${CMAKE_SOURCE_DIR}/../libc/)
----------------
shiltian wrote:
This change is fine, but I wonder why don't we just export libc's rpc as a target and then just link against the target, such that CMake will handle all the interface directories.
https://github.com/llvm/llvm-project/pull/117908
More information about the libc-commits
mailing list