[libc-commits] [libc] [llvm] [libc] Move libc server handlers to a shared header (PR #117908)

Shilei Tian via libc-commits libc-commits at lists.llvm.org
Wed Nov 27 12:30:08 PST 2024


================
@@ -445,15 +443,19 @@ rpc::Status handle_port_impl(rpc::Server::Port &port) {
   return rpc::SUCCESS;
 }
 
-int libc_handle_rpc_port(void *port, uint32_t num_lanes) {
+namespace rpc {
+// The implementation of this function currently lives in the utility directory
+// at 'utils/gpu/server/rpc_server.cpp'.
+rpc::Status handle_libc_opcodes(rpc::Server::Port &port, uint32_t num_lanes) {
   switch (num_lanes) {
   case 1:
-    return handle_port_impl<1>(*reinterpret_cast<rpc::Server::Port *>(port));
+    return handle_port_impl<1>(port);
----------------
shiltian wrote:

I find it confusing looking at the variable name of libc project. what is the rule here?

https://github.com/llvm/llvm-project/pull/117908


More information about the libc-commits mailing list