[libc-commits] [libc] 6de97e9 - [libc] Allow NVPTX targets to build in debug mode

Joseph Huber via libc-commits libc-commits at lists.llvm.org
Mon Nov 25 07:17:34 PST 2024


Author: Joseph Huber
Date: 2024-11-25T09:11:58-06:00
New Revision: 6de97e9a679aaf3148d467e4d4e1ea99ba55d555

URL: https://github.com/llvm/llvm-project/commit/6de97e9a679aaf3148d467e4d4e1ea99ba55d555
DIFF: https://github.com/llvm/llvm-project/commit/6de97e9a679aaf3148d467e4d4e1ea99ba55d555.diff

LOG: [libc] Allow NVPTX targets to build in debug mode

Summary:
This previously did not work, but recent improvements to the NVPTX
backend allow this to work now.

Added: 
    

Modified: 
    libc/cmake/modules/prepare_libc_gpu_build.cmake

Removed: 
    


################################################################################
diff  --git a/libc/cmake/modules/prepare_libc_gpu_build.cmake b/libc/cmake/modules/prepare_libc_gpu_build.cmake
index e20591b80e6f29..937bd22451c5fb 100644
--- a/libc/cmake/modules/prepare_libc_gpu_build.cmake
+++ b/libc/cmake/modules/prepare_libc_gpu_build.cmake
@@ -72,11 +72,6 @@ else()
 endif()
 set(LIBC_GPU_TARGET_ARCHITECTURE "${gpu_test_architecture}")
 
-# The NVPTX backend cannot currently handle objects created in debug mode.
-if(LIBC_TARGET_ARCHITECTURE_IS_NVPTX AND CMAKE_BUILD_TYPE STREQUAL "Debug")
-  set(LIBC_GPU_TESTS_DISABLED TRUE)
-endif()
-
 # Identify the GPU loader utility used to run tests.
 set(LIBC_GPU_LOADER_EXECUTABLE "" CACHE STRING "Executable for the GPU loader.")
 if(LIBC_GPU_LOADER_EXECUTABLE)


        


More information about the libc-commits mailing list