[libc-commits] [libc] [libc] Set default visibility for LLVM functions (PR #116686)

Nick Desaulniers via libc-commits libc-commits at lists.llvm.org
Thu Nov 21 08:52:08 PST 2024


nickdesaulniers wrote:

> If we're going this route it should put in config.json and also allow users to specify via CMake.
> I agree with @jhuber6, I think we should keep LLVM_LIBC_FUNCTION_ATTR and introduce a new config.json option to let you set the default (and if unset we should default to hidden).

Ah, I forgot to respond to this point yesterday. Of the three cases I cited above where the visibility is set to default downstream, NONE are using CMake.  So do I want to wire up a cmake option for this? Not particularly, since it doesn't seem like downstreams that care will be able to use the resulting option.

https://github.com/llvm/llvm-project/pull/116686


More information about the libc-commits mailing list