[libc-commits] [libc] [libc] Fix fpbits test running 80bit ld everywhere (PR #115937)

[Nick Desaulniers via libc-commits]

nickdesaulniers wrote:

Ack. Please land this. I can clean it up properly later (re-enabling long
double is double).

On Tue, Nov 12, 2024, 12:46 PM llvmbot ***@***.***> wrote:

> @llvm/pr-subscribers-libc
> <https://github.com/orgs/llvm/teams/pr-subscribers-libc>
>
> Author: Michael Jones (michaelrj-google)
> Changes
>
> After #115084 the 80 bit long double tests error if sizeof(long double)
> isn't 96 or 128 bits. This caused failures in long double is double
> systems (since long double is 64 bits) so I've disabled the 80 bit long
> double tests on systems that don't use them.
> ------------------------------
>
> Full diff: https://github.com/llvm/llvm-project/pull/115937.diff
>
> 1 Files Affected:
>
>    - (modified) libc/test/src/__support/FPUtil/fpbits_test.cpp (+2)
>
> diff --git a/libc/test/src/__support/FPUtil/fpbits_test.cpp b/libc/test/src/__support/FPUtil/fpbits_test.cpp
> index edb04c24ae3876..6953d3aace58f3 100644
> --- a/libc/test/src/__support/FPUtil/fpbits_test.cpp
> +++ b/libc/test/src/__support/FPUtil/fpbits_test.cpp
> @@ -124,6 +124,7 @@ TEST(LlvmLibcFPBitsTest, FPType_IEEE754_Binary128) {
>        UInt128(Rep::quiet_nan()));
>  }
>
> +#ifdef LIBC_TYPES_LONG_DOUBLE_IS_X86_FLOAT80
>  TEST(LlvmLibcFPBitsTest, FPType_X86_Binary80) {
>    using Rep = FPRep<FPType::X86_Binary80>;
>
> @@ -269,6 +270,7 @@ TEST(LlvmLibcFPBitsTest, FPType_X86_Binary80_IsNan) {
>  #error "unhandled long double type"
>  #endif
>  }
> +#endif // LIBC_TYPES_LONG_DOUBLE_IS_X86_FLOAT80
>
>  enum class FP {
>    ZERO,
>
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/llvm/llvm-project/pull/115937#issuecomment-2471548533>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAN5IX2V32HRB55DSM7COB32AJSKHAVCNFSM6AAAAABRU5V2TKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZRGU2DQNJTGM>
> .
> You are receiving this because your review was requested.Message ID:
> ***@***.***>
>


https://github.com/llvm/llvm-project/pull/115937